Skip to content

Add BytesIO to safe_globals - #2074

Merged
tdene merged 8 commits into
NVIDIA:mainfrom
tdene:tde/safe_globals
Nov 6, 2025
Merged

Add BytesIO to safe_globals#2074
tdene merged 8 commits into
NVIDIA:mainfrom
tdene:tde/safe_globals

Conversation

@tdene

@tdene tdene commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

What does this PR do ?

Some checkpoints cannot be loaded with the current set of safe_globals. This PR adds io.BytesIO to this set.

Megatron Inference and Megatron RL tests have both encountered this issue.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@tdene
tdene requested review from a team as code owners October 31, 2025 19:56
@ko3n1g ko3n1g added this to the Core 0.16 milestone Oct 31, 2025

@mathemakitten mathemakitten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We had added these to examples/inference/gpt/gpt_dynamic_inference.py in !3965 when I found that they were needed for backward compatibility to run inference with existing MCore checkpoints, so it would be best to move them to globals anyway.

@copy-pr-bot

copy-pr-bot Bot commented Nov 5, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@tdene

tdene commented Nov 5, 2025

Copy link
Copy Markdown
Contributor Author

/ok to run 6230ddd

@tdene

tdene commented Nov 5, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test 6230ddd

Comment thread examples/inference/gpt/gpt_dynamic_inference.py

@dimapihtar dimapihtar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@tdene

tdene commented Nov 5, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test 52596d0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants