fix(studio): Fix Base Model filtering on the Virtual Models Grid - #819
Conversation
Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughStudio model filters now support partial base-model name matching, workspace-qualified option values, and workspace-qualified default model entity filters. ChangesStudio model filters
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@web/packages/studio/src/components/dataViews/VirtualModelsDataView/index.tsx`:
- Around line 80-85: The qualifiedDefaultModelEntity construction currently
prefixes bare model names with the current workspace, which can misidentify
default-workspace models. Update BaseModelSearchFilterField option values or the
selection-resolution flow to retain and use the selected model’s workspace when
constructing the filter, while preserving already-qualified values and the
existing undefined behavior.
- Around line 81-85: Update the memo computing qualifiedDefaultModelEntity to
include workspace in its dependency list, ensuring the qualified model
identifier recalculates when the workspace changes and preventing stale
filter/API queries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 7526825c-d434-48e2-8e34-1cd8b9e4ced8
📒 Files selected for processing (2)
web/packages/studio/src/components/FilterFields/BaseModelSearchFilterField.tsxweb/packages/studio/src/components/dataViews/VirtualModelsDataView/index.tsx
|
Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>
f899f60 to
4c037c8
Compare
Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>
8fbd872 to
6604e80
Compare
https://nvbugspro.nvidia.com/bug/6484469
https://nvbugspro.nvidia.com/bug/6484441
Summary by CodeRabbit