Skip to content

fix(studio): Fix Base Model filtering on the Virtual Models Grid - #819

Merged
htolentino-nvidia merged 5 commits into
mainfrom
NVB6484469-guardrails-filter-fix/htolentino
Jul 21, 2026
Merged

fix(studio): Fix Base Model filtering on the Virtual Models Grid#819
htolentino-nvidia merged 5 commits into
mainfrom
NVB6484469-guardrails-filter-fix/htolentino

Conversation

@htolentino-nvidia

@htolentino-nvidia htolentino-nvidia commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

https://nvbugspro.nvidia.com/bug/6484469
https://nvbugspro.nvidia.com/bug/6484441

Summary by CodeRabbit

  • Bug Fixes
    • Improved model search so partial queries return results using name matching rather than requiring exact input.
    • Updated the model selector to store workspace-qualified option values (while keeping the same displayed labels) to avoid collisions from similarly named models.
    • Fixed virtual model default selection by automatically qualifying unscoped default values with the current workspace, leaving already-qualified values unchanged.

Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>
@htolentino-nvidia
htolentino-nvidia requested review from a team as code owners July 21, 2026 17:39
@github-actions github-actions Bot added the fix label Jul 21, 2026
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Studio model filters now support partial base-model name matching, workspace-qualified option values, and workspace-qualified default model entity filters.

Changes

Studio model filters

Layer / File(s) Summary
Base model partial matching
web/packages/studio/src/components/FilterFields/BaseModelSearchFilterField.tsx
Non-empty searches use a $like filter on name; options use workspace/name values while displaying model names as labels.
Workspace-qualified virtual model filtering
web/packages/studio/src/components/dataViews/VirtualModelsDataView/index.tsx
Unqualified default_model_entity values receive the current workspace prefix, while qualified values remain unchanged. The memoized filter updates when workspace changes.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately captures the main Studio change: fixing Base Model filtering on the Virtual Models Grid.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch NVB6484469-guardrails-filter-fix/htolentino

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@web/packages/studio/src/components/dataViews/VirtualModelsDataView/index.tsx`:
- Around line 80-85: The qualifiedDefaultModelEntity construction currently
prefixes bare model names with the current workspace, which can misidentify
default-workspace models. Update BaseModelSearchFilterField option values or the
selection-resolution flow to retain and use the selected model’s workspace when
constructing the filter, while preserving already-qualified values and the
existing undefined behavior.
- Around line 81-85: Update the memo computing qualifiedDefaultModelEntity to
include workspace in its dependency list, ensuring the qualified model
identifier recalculates when the workspace changes and preventing stale
filter/API queries.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7526825c-d434-48e2-8e34-1cd8b9e4ced8

📥 Commits

Reviewing files that changed from the base of the PR and between 433fa61 and a003f3d.

📒 Files selected for processing (2)
  • web/packages/studio/src/components/FilterFields/BaseModelSearchFilterField.tsx
  • web/packages/studio/src/components/dataViews/VirtualModelsDataView/index.tsx

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 26394/34046 77.5% 61.8%
Integration Tests 15161/32671 46.4% 18.6%

Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>
@htolentino-nvidia
htolentino-nvidia force-pushed the NVB6484469-guardrails-filter-fix/htolentino branch from f899f60 to 4c037c8 Compare July 21, 2026 18:16
Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>
@htolentino-nvidia
htolentino-nvidia force-pushed the NVB6484469-guardrails-filter-fix/htolentino branch from 8fbd872 to 6604e80 Compare July 21, 2026 18:26
@htolentino-nvidia
htolentino-nvidia added this pull request to the merge queue Jul 21, 2026
Merged via the queue into main with commit ad2d7b5 Jul 21, 2026
58 checks passed
@htolentino-nvidia
htolentino-nvidia deleted the NVB6484469-guardrails-filter-fix/htolentino branch July 21, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants