fix(studio): Add a model dropdown for Base Model filtering on the Virtual Model Grid - #755
Conversation
Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesVirtual model filtering
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
steramae-nvidia
left a comment
There was a problem hiding this comment.
why the change from $like to $eq?
|
Good question @steramae-nvidia, I do think when the user selects a specific model on the dropdown they wouldn't expect to see models that would be also matched by $like, since they clicked llama-8b for example (and not any other llama variant on the dropdown) I wouldn't want to display base models like llama-8b-custom-ft. Now, this was requested by QA, I'm not super sure the dropdown for this type of filtering is the more useful pattern here. The user can't really filter by all nemotron models if they wanted so, but at least here we're matching the existing behaviour on in the custom models page. |
https://linear.app/nvidia/issue/ASTD-307/virtual-models-default-model-filter-is-a-free-text-input-with-no
Summary by CodeRabbit
New Features
Bug Fixes