Skip to content

fix(studio): Fix Base Model filtering on the Virtual Models Grid #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htolentino-nvidia merged 5 commits into from
Jul 21, 2026
Merged

fix(studio): Fix Base Model filtering on the Virtual Models Grid #819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a003f3d
Fix Base Model filtering on the Virtual Models Grid
htolentino-nvidia Jul 21, 2026
4c037c8
Small fixes
htolentino-nvidia Jul 21, 2026
6604e80
Fix workspace issues
htolentino-nvidia Jul 21, 2026
d305e6f
Merge branch 'main' into NVB6484469-guardrails-filter-fix/htolentino
htolentino-nvidia Jul 21, 2026
fb68b96
Merge branch 'main' into NVB6484469-guardrails-filter-fix/htolentino
htolentino-nvidia Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions web/packages/studio/src/components/FilterFields/BaseModelSearchFilterField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const BaseModelSearchFilterFieldSingle: FC<

const { models, fetchNextPage, hasNextPage, isFetchingNextPage, isLoading } = useBaseModels({
workspace,
filter: searchInput.trim() ? { name: searchInput.trim() } : undefined,
filter: searchInput.trim() ? { name: { $like: searchInput.trim() } } : undefined,
sort: ModelEntitySortField.name,
});

Expand All @@ -52,7 +52,11 @@ const BaseModelSearchFilterFieldSingle: FC<
}, [selectedBaseModel, form]);

const options = useMemo(
() => models.map((model) => ({ value: model.name ?? '', label: model.name ?? '' })),
() =>
models.map((model) => ({
value: `${model.workspace}/${model.name ?? ''}`,
label: model.name ?? '',
})),
[models]
);

Expand Down
12 changes: 10 additions & 2 deletions web/packages/studio/src/components/dataViews/VirtualModelsDataView/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,21 @@ export const VirtualModelsDataView: FC<VirtualModelsDataViewProps> = ({
const columnFilters = new Map(dataViewState.debouncedColumnFilters.map((f) => [f.id, f.value]));
const name = dataViewState.debouncedSearchBar || undefined;
const defaultModelEntity = columnFilters.get('default_model_entity') as string | undefined;
// API requires workspace-qualified form ("default/model-name"); dropdown yields bare names.
const qualifiedDefaultModelEntity = defaultModelEntity
? defaultModelEntity.includes('/')
? defaultModelEntity
: `${workspace}/${defaultModelEntity}`
: undefined;
Comment thread
htolentino-nvidia marked this conversation as resolved.
Comment thread
coderabbitai[bot] marked this conversation as resolved.
const createdAt = columnFilters.get('created_at') as DatetimeFilter | undefined;
return withOperators<VirtualModelFilter>({
...(name ? { name: { $like: name } } : {}),
...(defaultModelEntity ? { default_model_entity: { $eq: defaultModelEntity } } : {}),
...(qualifiedDefaultModelEntity
? { default_model_entity: { $eq: qualifiedDefaultModelEntity } }
: {}),
...(createdAt ? { created_at: createdAt } : {}),
});
}, [dataViewState.debouncedSearchBar, dataViewState.debouncedColumnFilters]);
}, [dataViewState.debouncedSearchBar, dataViewState.debouncedColumnFilters, workspace]);

const { data, isFetching, error } = useListVirtualModels(
workspace,
Expand Down