fix(studio): React Router version upgrade - #1049
Merged
Merged
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe web packages migrate from ChangesReact Router migration
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
Contributor
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 7
🧹 Nitpick comments (1)
web/packages/studio/src/routes/index.test.tsx (1)
8-14: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winRemove the redundant route decoding.
react-router@8.3.0preserves:ingeneratePathparameters. Remove thedecodeURIComponentcalls and update the comment.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/packages/studio/src/routes/index.test.tsx` around lines 8 - 14, Remove the redundant decodeURIComponent calls in the route-helper tests and update the adjacent placeholder workspace comment to state that generatePath preserves the colon in React Router 8.3.0. Keep the raw :workspace placeholder and route comparisons unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/packages/common/src/hooks/useQueryParams/index.test.tsx`:
- Line 7: Update the useQueryParams import in the test file to use the
configured `@nemo/common` package alias instead of the relative './index' path,
while leaving the imported symbol unchanged.
In `@web/packages/studio/src/components/filesets/AddToFolderModal/index.tsx`:
- Around line 189-191: Update every caller of getFilesetDetailsRoute to pass raw
fileset and folder values, removing encodeURIComponent and
getEntityReference(..., { encode: true }) pre-encoding while preserving existing
route construction. Add regression coverage for fileset names containing %, /,
#, and spaces, verifying useParams receives the original values.
In `@web/packages/studio/src/components/Layouts/NavigationDrawer/index.test.tsx`:
- Line 12: Update the RouterProvider import in the navigation drawer test to use
the DOM-specific export from react-router/dom while retaining createMemoryRouter
from react-router, so the test uses the intended DOM flushSync behavior.
In `@web/packages/studio/src/routes/DataDesignerJobBuildRoute/index.test.tsx`:
- Line 11: Update the imports in the test setup to keep createMemoryRouter from
react-router while importing RouterProvider from react-router/dom, ensuring the
happy-dom suite uses ReactDOM-based router updates.
In `@web/packages/studio/src/routes/groups/evaluationRoutes.tsx`:
- Line 8: Update the import in the routing module to import RouteObject as a
type-only symbol while retaining Navigate as a runtime import, satisfying
verbatimModuleSyntax without changing route behavior.
In `@web/packages/studio/src/routes/groups/intakeRoutes.tsx`:
- Line 10: Update the imports in the intake routes module so the type-only
symbols FC and RouteObject use import type rather than runtime imports, while
preserving any value imports such as Navigate. Run the repository pre-commit
checks after making the change.
In `@web/packages/studio/src/tests/util/render.tsx`:
- Line 10: Update the imports in the test helper to source createMemoryRouter,
MemoryRouter, and RouterProvider from react-router/dom, while importing
RouteObject as a type-only symbol from react-router. Preserve the existing usage
of these router APIs.
---
Nitpick comments:
In `@web/packages/studio/src/routes/index.test.tsx`:
- Around line 8-14: Remove the redundant decodeURIComponent calls in the
route-helper tests and update the adjacent placeholder workspace comment to
state that generatePath preserves the colon in React Router 8.3.0. Keep the raw
:workspace placeholder and route comparisons unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 109b3196-6149-45db-a021-c9f382ff196b
⛔ Files ignored due to path filters (1)
web/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (210)
web/packages/common/package.jsonweb/packages/common/src/components/buttons/DownloadEvaluationResultsButton.tsxweb/packages/common/src/hooks/useQueryParams/index.test.tsxweb/packages/common/src/hooks/useQueryParams/index.tsweb/packages/common/src/hooks/useStudioDataViewState/filterFieldMap.integration.test.tsxweb/packages/common/src/hooks/useStudioDataViewState/index.test.tsxweb/packages/common/src/hooks/useStudioDataViewState/index.tsweb/packages/common/src/hooks/useTableFilters/index.test.tsxweb/packages/common/src/hooks/useTableFilters/index.tsweb/packages/common/src/utils/useQueryFromSearchParams.test.tsweb/packages/common/src/utils/useQueryFromSearchParams.tsweb/packages/storybook/.storybook/preview.tsxweb/packages/storybook/package.jsonweb/packages/studio/package.jsonweb/packages/studio/src/App.tsxweb/packages/studio/src/components/AnonymizerJobActionsMenu/index.tsxweb/packages/studio/src/components/Breadcrumbs/index.tsxweb/packages/studio/src/components/CustomizeModelModal/index.test.tsxweb/packages/studio/src/components/CustomizeModelModal/index.tsxweb/packages/studio/src/components/DataDesignerJobActionsMenu/index.tsxweb/packages/studio/src/components/DatasetCreateModal/index.test.tsxweb/packages/studio/src/components/DatasetCreateModal/index.tsxweb/packages/studio/src/components/DatasetInputFile/DatasetInputFile.test.tsxweb/packages/studio/src/components/DatasetsTable/index.test.tsxweb/packages/studio/src/components/DatasetsTable/index.tsxweb/packages/studio/src/components/DatasetsTable/useDatasetsTable.tsweb/packages/studio/src/components/DocumentationButton/index.test.tsxweb/packages/studio/src/components/ErrorPanel/index.test.tsxweb/packages/studio/src/components/ErrorPanel/index.tsxweb/packages/studio/src/components/FilesetCreateModal/index.test.tsxweb/packages/studio/src/components/FilesetCreateModal/index.tsxweb/packages/studio/src/components/ImportFileContent/index.tsxweb/packages/studio/src/components/IntakeDetail/IntakeComponents/spanKeyValues.tsxweb/packages/studio/src/components/IntakeDetail/IntakeComponents/traceKeyValues.tsxweb/packages/studio/src/components/IntakeDetail/SessionDetailView.tsxweb/packages/studio/src/components/IntakeDetail/TraceSpanAccordions.tsxweb/packages/studio/src/components/IntakeLists/IntakeSpansTable.test.tsxweb/packages/studio/src/components/IntakeLists/IntakeSpansTable.tsxweb/packages/studio/src/components/IntakeLists/IntakeTracesTable.test.tsxweb/packages/studio/src/components/IntakeLists/IntakeTracesTable.tsxweb/packages/studio/src/components/IntakeLists/defaultStartedAtFilter.tsweb/packages/studio/src/components/Layouts/GlobalNav/index.test.tsxweb/packages/studio/src/components/Layouts/GlobalNav/index.tsxweb/packages/studio/src/components/Layouts/NavigationDrawer/components/CollapsedNavItem.tsxweb/packages/studio/src/components/Layouts/NavigationDrawer/components/NavItem.tsxweb/packages/studio/src/components/Layouts/NavigationDrawer/index.test.tsxweb/packages/studio/src/components/Layouts/NavigationDrawer/index.tsxweb/packages/studio/src/components/Layouts/UnauthorizedWorkspace/index.test.tsxweb/packages/studio/src/components/ModelChatPanel/ModelChatPanel.test.tsxweb/packages/studio/src/components/NewCustomizationForm/index.tsxweb/packages/studio/src/components/NewDataDesignerJobForm/index.tsxweb/packages/studio/src/components/OriginatingInsightLink/index.tsxweb/packages/studio/src/components/QuickActionsMenu/QuickActionsMenuDefault/index.test.tsxweb/packages/studio/src/components/SafeSynthesizerFilesetPreview/index.test.tsxweb/packages/studio/src/components/SafeSynthesizerNavigation/index.test.tsxweb/packages/studio/src/components/SafeSynthesizerNavigation/index.tsxweb/packages/studio/src/components/UserPopover/index.test.tsxweb/packages/studio/src/components/WelcomeTour/index.tsxweb/packages/studio/src/components/WorkspaceCreateModal/index.tsxweb/packages/studio/src/components/chat/ChatEmptyState.tsxweb/packages/studio/src/components/dataViews/AgentEvaluationsDataView/index.tsxweb/packages/studio/src/components/dataViews/AgentsDataView/index.test.tsxweb/packages/studio/src/components/dataViews/AgentsDataView/index.tsxweb/packages/studio/src/components/dataViews/AnonymizerJobsDataView/index.tsxweb/packages/studio/src/components/dataViews/CustomModelsDataView/CustomizeModelButton/index.test.tsxweb/packages/studio/src/components/dataViews/CustomModelsDataView/index.tsxweb/packages/studio/src/components/dataViews/DataDesignerJobsDataView/index.tsxweb/packages/studio/src/components/dataViews/EvaluationResultsDataView/index.tsxweb/packages/studio/src/components/dataViews/EvaluationSessionsDataView/index.tsxweb/packages/studio/src/components/dataViews/ExperimentDataView/index.tsxweb/packages/studio/src/components/dataViews/GuardrailChecksDataView/index.test.tsxweb/packages/studio/src/components/dataViews/GuardrailsDataView/GuardrailsDataView.test.tsxweb/packages/studio/src/components/dataViews/JobsDataView/index.tsxweb/packages/studio/src/components/dataViews/SafeSynthesizerJobsDataView/index.tsxweb/packages/studio/src/components/dataViews/SecretsDataView/index.test.tsxweb/packages/studio/src/components/evaluation/ButtonLaunchEvaluation.test.tsxweb/packages/studio/src/components/evaluation/ButtonLaunchEvaluation.tsxweb/packages/studio/src/components/evaluation/Configurations/form/InputFile.test.tsxweb/packages/studio/src/components/evaluation/Configurations/form/MetricsCheckboxes.test.tsxweb/packages/studio/src/components/evaluation/DatasetFileLink.tsxweb/packages/studio/src/components/evaluation/EvaluationModelSelect.test.tsxweb/packages/studio/src/components/evaluation/Jobs/DetailsPanel.test.tsxweb/packages/studio/src/components/evaluation/Jobs/DetailsPanel.tsxweb/packages/studio/src/components/filesets/AddToFolderModal/index.tsxweb/packages/studio/src/components/sidePanels/AgentPanels/AgentPanel/AgentDetailsContent.tsxweb/packages/studio/src/components/sidePanels/AgentPanels/AgentPanel/index.test.tsxweb/packages/studio/src/components/sidePanels/CustomizationConfigSidePanel/index.test.tsxweb/packages/studio/src/components/sidePanels/MetricRunSidePanel/MetricRunSidePanel.stories.tsxweb/packages/studio/src/components/sidePanels/MetricRunSidePanel/index.tsxweb/packages/studio/src/hooks/evaluation/useAutofillFromSearchParams.tsweb/packages/studio/src/hooks/useComparisonResults/index.tsxweb/packages/studio/src/hooks/useSelectedDatasetId/index.tsweb/packages/studio/src/hooks/useWorkspaceFromPath/index.tsweb/packages/studio/src/providers/workspace/WorkspaceProvider.tsxweb/packages/studio/src/routes/AnonymizerBuilderRoute/components/AnonymizerBuilderForm.tsxweb/packages/studio/src/routes/AnonymizerJobDetailRoute/index.tsxweb/packages/studio/src/routes/AnonymizerListRoute/index.tsxweb/packages/studio/src/routes/AuthSuccessRoute/index.tsxweb/packages/studio/src/routes/CustomizationJobDetailsRoute/DetailActions.tsxweb/packages/studio/src/routes/CustomizationJobListRoute/index.tsxweb/packages/studio/src/routes/DashboardLandingRoute/index.tsxweb/packages/studio/src/routes/DataDesignerJobBuildRoute/index.test.tsxweb/packages/studio/src/routes/DataDesignerJobBuildRoute/index.tsxweb/packages/studio/src/routes/DataDesignerJobDetailsRoute/JobOutputFilesetSection.tsxweb/packages/studio/src/routes/DataDesignerJobDetailsRoute/index.tsxweb/packages/studio/src/routes/DataDesignerJobListRoute/index.tsxweb/packages/studio/src/routes/DeploymentsListRoute/index.tsxweb/packages/studio/src/routes/EvaluationSessionDetailRoute/index.tsxweb/packages/studio/src/routes/ExperimentRoute/ExperimentCard.tsxweb/packages/studio/src/routes/FilesetDetailRoute/index.test.tsxweb/packages/studio/src/routes/FilesetDetailRoute/index.tsxweb/packages/studio/src/routes/FilesetListRoute/PanelManagement/index.tsxweb/packages/studio/src/routes/FilesetListRoute/index.test.tsxweb/packages/studio/src/routes/FilesetListRoute/index.tsxweb/packages/studio/src/routes/FilesetNewRoute/index.tsxweb/packages/studio/src/routes/FilesetNewRoute/useCreateFileset.tsweb/packages/studio/src/routes/InferenceProvidersListRoute/index.tsxweb/packages/studio/src/routes/IntakeLayout/index.tsxweb/packages/studio/src/routes/IntakeSessionDetailRoute/index.test.tsxweb/packages/studio/src/routes/IntakeSessionDetailRoute/index.tsxweb/packages/studio/src/routes/ModelCompareRoute/index.test.tsxweb/packages/studio/src/routes/ModelCompareRoute/index.tsxweb/packages/studio/src/routes/NewCustomizationRoute/index.tsxweb/packages/studio/src/routes/NewDataDesignerJobRoute/index.tsxweb/packages/studio/src/routes/PageLayout/index.tsxweb/packages/studio/src/routes/PromptTuningFormRoute/index.test.tsxweb/packages/studio/src/routes/PromptTuningFormRoute/index.tsxweb/packages/studio/src/routes/RootLayout/WorkspaceGuard.test.tsxweb/packages/studio/src/routes/RootLayout/index.tsxweb/packages/studio/src/routes/RootRedirect/index.tsxweb/packages/studio/src/routes/SafeSynthesizerJobDetailsRoute/components/ReportSummaryPanel.test.tsxweb/packages/studio/src/routes/SafeSynthesizerJobDetailsRoute/components/ReportSummaryPanel.tsxweb/packages/studio/src/routes/SafeSynthesizerJobDetailsRoute/index.test.tsxweb/packages/studio/src/routes/SafeSynthesizerJobReportRoute/index.test.tsxweb/packages/studio/src/routes/SafeSynthesizerListRoute/index.test.tsxweb/packages/studio/src/routes/SafeSynthesizerListRoute/index.tsxweb/packages/studio/src/routes/SafeSynthesizerNewRoute/index.test.tsxweb/packages/studio/src/routes/SafeSynthesizerNewRoute/index.tsxweb/packages/studio/src/routes/WorkspaceBaseModelsRoute/index.test.tsxweb/packages/studio/src/routes/WorkspaceBaseModelsRoute/index.tsxweb/packages/studio/src/routes/WorkspaceDashboardRoute/DashboardCard.tsxweb/packages/studio/src/routes/WorkspaceDashboardRoute/index.tsxweb/packages/studio/src/routes/WorkspaceSettingsRoute/DeleteWorkspaceModal/index.tsxweb/packages/studio/src/routes/WorkspaceSettingsRoute/index.tsxweb/packages/studio/src/routes/agents/AgentDeploymentsListRoute/index.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/EvaluationsTab.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/index.tsxweb/packages/studio/src/routes/agents/AgentEvaluationsRoute/AgentEvaluationDetailRoute.tsxweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/components/EmptyState.tsxweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/components/SuggestionTile.tsxweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/useAgentOptimizations.tsxweb/packages/studio/src/routes/agents/AgentsListRoute/CloneAgentModal/index.tsxweb/packages/studio/src/routes/agents/AgentsListRoute/CreateExampleAgentModal/index.tsxweb/packages/studio/src/routes/agents/AgentsListRoute/index.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/ClaudeCodeChatThread.test.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/ClaudeCodeChatThread.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/ClaudeCodeLayout.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/ClaudeCodeStudioLink.test.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/ClaudeCodeStudioLink.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/ClaudeCodeTopBarChat.test.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/ClaudeCodeTopBarChat.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/JobProgressToolCall.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/context/ClaudeCodeChatProvider.test.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/context/ClaudeCodeChatProvider.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/historyPanel/ArtifactSections.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/index.test.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/index.tsxweb/packages/studio/src/routes/evaluation/EvaluationLayout/index.tsxweb/packages/studio/src/routes/evaluation/EvaluationResultsLayout/index.tsxweb/packages/studio/src/routes/groups/agentRoutes.tsxweb/packages/studio/src/routes/groups/anonymizerRoutes.tsxweb/packages/studio/src/routes/groups/baseModelsRoutes.tsxweb/packages/studio/src/routes/groups/customizationRoutes.tsxweb/packages/studio/src/routes/groups/dashboardRoutes.tsxweb/packages/studio/src/routes/groups/dataDesignerRoutes.tsxweb/packages/studio/src/routes/groups/deploymentRoutes.tsxweb/packages/studio/src/routes/groups/evaluationRoutes.tsxweb/packages/studio/src/routes/groups/experimentRoutes.tsxweb/packages/studio/src/routes/groups/filesetRoutes.tsxweb/packages/studio/src/routes/groups/guardrailsRoutes.tsxweb/packages/studio/src/routes/groups/inferenceProviderRoutes.tsxweb/packages/studio/src/routes/groups/intakeRoutes.tsxweb/packages/studio/src/routes/groups/jobRoutes.tsxweb/packages/studio/src/routes/groups/memberRoutes.tsxweb/packages/studio/src/routes/groups/modelCompareRoutes.tsxweb/packages/studio/src/routes/groups/optimizerRoutes.tsxweb/packages/studio/src/routes/groups/safeSynthesizerRoutes.tsxweb/packages/studio/src/routes/groups/secretsRoutes.tsxweb/packages/studio/src/routes/groups/settingsRoutes.tsxweb/packages/studio/src/routes/groups/virtualModelsRoutes.tsxweb/packages/studio/src/routes/guardrails/GuardrailChecksTab/index.test.tsxweb/packages/studio/src/routes/guardrails/GuardrailDetailRoute/index.test.tsxweb/packages/studio/src/routes/guardrails/GuardrailDetailRoute/index.tsxweb/packages/studio/src/routes/guardrails/GuardrailsRoute/index.test.tsxweb/packages/studio/src/routes/guardrails/GuardrailsRoute/index.tsxweb/packages/studio/src/routes/index.test.tsxweb/packages/studio/src/routes/index.tsxweb/packages/studio/src/routes/optimizer/InsightTracesTable/index.tsxweb/packages/studio/src/routes/optimizer/OptimizerInsightRoute/InsightExperiments.tsxweb/packages/studio/src/routes/optimizer/OptimizerInsightRoute/index.test.tsxweb/packages/studio/src/routes/optimizer/OptimizerInsightRoute/index.tsxweb/packages/studio/src/routes/optimizer/OptimizerRoute/index.tsxweb/packages/studio/src/routes/utils.test.tsweb/packages/studio/src/routes/utils.tsweb/packages/studio/src/tests/create-a-model.test.tsxweb/packages/studio/src/tests/util/LocationDisplay.tsxweb/packages/studio/src/tests/util/mockUseParams.tsweb/packages/studio/src/tests/util/render.tsxweb/packages/studio/vitest.setup.tsxweb/pnpm-workspace.yaml
💤 Files with no reviewable changes (2)
- web/packages/common/package.json
- web/packages/studio/package.json
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@web/packages/studio/src/routes/DataDesignerJobDetailsRoute/JobOutputFilesetSection.tsx`:
- Around line 125-131: Update handleDatasetClickFromPreview and
handleFolderClickFromPreview to pass the full namespaced fileset ID, combining
filesetWorkspace and filesetName as the adjacent Link does, while preserving
folderPath for folder navigation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: edcedb8a-1711-4703-97d1-118479cadd40
📒 Files selected for processing (30)
web/packages/common/src/hooks/useQueryParams/index.test.tsxweb/packages/studio/src/components/CustomizeModelModal/index.test.tsxweb/packages/studio/src/components/DatasetCreateModal/index.tsxweb/packages/studio/src/components/ErrorPanel/index.test.tsxweb/packages/studio/src/components/Layouts/GlobalNav/index.test.tsxweb/packages/studio/src/components/Layouts/NavigationDrawer/index.test.tsxweb/packages/studio/src/components/UserPopover/index.test.tsxweb/packages/studio/src/components/dataViews/CustomModelsDataView/CustomizeModelButton/index.test.tsxweb/packages/studio/src/components/dataViews/GuardrailChecksDataView/index.test.tsxweb/packages/studio/src/components/dataViews/GuardrailsDataView/GuardrailsDataView.test.tsxweb/packages/studio/src/components/evaluation/ButtonLaunchEvaluation.test.tsxweb/packages/studio/src/components/sidePanels/CustomizationConfigSidePanel/index.test.tsxweb/packages/studio/src/routes/DashboardLandingRoute/index.test.tsxweb/packages/studio/src/routes/DataDesignerJobBuildRoute/index.test.tsxweb/packages/studio/src/routes/DataDesignerJobDetailsRoute/JobOutputFilesetSection.tsxweb/packages/studio/src/routes/FilesetListRoute/PanelManagement/index.tsxweb/packages/studio/src/routes/FilesetListRoute/index.test.tsxweb/packages/studio/src/routes/FilesetListRoute/index.tsxweb/packages/studio/src/routes/FilesetNewRoute/useCreateFileset.tsweb/packages/studio/src/routes/NoMatchRoute/index.test.tsxweb/packages/studio/src/routes/PromptTuningFormRoute/index.test.tsxweb/packages/studio/src/routes/RootRedirect/index.test.tsxweb/packages/studio/src/routes/SafeSynthesizerListRoute/index.test.tsxweb/packages/studio/src/routes/WorkspaceDashboardRoute/index.test.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/ClaudeCodeChatThread.test.tsxweb/packages/studio/src/routes/groups/evaluationRoutes.tsxweb/packages/studio/src/routes/groups/intakeRoutes.tsxweb/packages/studio/src/routes/utils.test.tsweb/packages/studio/src/tests/create-a-model.test.tsxweb/packages/studio/src/tests/util/render.tsx
🚧 Files skipped from review as they are similar to previous changes (24)
- web/packages/studio/src/routes/groups/evaluationRoutes.tsx
- web/packages/studio/src/components/Layouts/GlobalNav/index.test.tsx
- web/packages/studio/src/routes/agents/ClaudeCodeChatRoute/ClaudeCodeChatThread.test.tsx
- web/packages/studio/src/routes/PromptTuningFormRoute/index.test.tsx
- web/packages/studio/src/components/sidePanels/CustomizationConfigSidePanel/index.test.tsx
- web/packages/studio/src/routes/FilesetNewRoute/useCreateFileset.ts
- web/packages/studio/src/components/evaluation/ButtonLaunchEvaluation.test.tsx
- web/packages/studio/src/components/ErrorPanel/index.test.tsx
- web/packages/studio/src/routes/SafeSynthesizerListRoute/index.test.tsx
- web/packages/studio/src/routes/FilesetListRoute/index.tsx
- web/packages/studio/src/components/DatasetCreateModal/index.tsx
- web/packages/studio/src/routes/FilesetListRoute/index.test.tsx
- web/packages/studio/src/components/CustomizeModelModal/index.test.tsx
- web/packages/studio/src/components/dataViews/GuardrailChecksDataView/index.test.tsx
- web/packages/studio/src/routes/groups/intakeRoutes.tsx
- web/packages/studio/src/routes/FilesetListRoute/PanelManagement/index.tsx
- web/packages/studio/src/routes/DataDesignerJobBuildRoute/index.test.tsx
- web/packages/studio/src/tests/util/render.tsx
- web/packages/studio/src/components/UserPopover/index.test.tsx
- web/packages/common/src/hooks/useQueryParams/index.test.tsx
- web/packages/studio/src/tests/create-a-model.test.tsx
- web/packages/studio/src/components/dataViews/GuardrailsDataView/GuardrailsDataView.test.tsx
- web/packages/studio/src/components/Layouts/NavigationDrawer/index.test.tsx
- web/packages/studio/src/components/dataViews/CustomModelsDataView/CustomizeModelButton/index.test.tsx
steramae-nvidia
force-pushed
the
steramae/react-router-upgrade
branch
3 times, most recently
from
August 4, 2026 20:23
1a864d8 to
017f92f
Compare
marcusds
approved these changes
Aug 4, 2026
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
steramae-nvidia
force-pushed
the
steramae/react-router-upgrade
branch
from
August 4, 2026 23:28
f5eae27 to
8c50c06
Compare
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(studio): React Router version upgrade
Signed-off-by: Sean Teramae steramae@nvidia.com
fix some more issues, v8
Signed-off-by: Sean Teramae steramae@nvidia.com
Summary by CodeRabbit
Enhancements
Bug Fixes
Tests