fix(studio): stop evaluation fileset links 404ing by default - #1199
Merged
htolentino-nvidia merged 1 commit intoAug 10, 2026
Conversation
The Eval Config, Artifacts, and Dataset links on the evaluation pages all pointed at the unified fileset detail page via getFilesetDetailRoute. That route is registered only when FILESET_DETAILS_ENABLED is on, and the flag defaults to false, so on a default deployment every one of those links landed on a 404. Add getFilesetRoute, which picks the route that is actually registered and normalizes the reference for it: the detail page takes a bare name and derives the namespace itself, while the panel route needs a full namespace/name entity reference. Point the evaluation links at it. FilesetListRoute and useCreateFileset already guarded on the flag and are unchanged. FilesetCreateModal calls getFilesetDetailRoute directly, but both of its entry points are themselves flag-gated. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>
Contributor
📝 WalkthroughWalkthroughThe PR adds ChangesFileset routing
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (2)
web/packages/studio/src/routes/utils.test.ts (1)
70-84: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winCover the enabled route branch.
These tests assert only the legacy panel URL. Add controlled tests with
FILESET_DETAILS_ENABLEDenabled for bare and namespaced references, includingoptions.tab. This protects the detail route and its reference normalization.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/packages/studio/src/routes/utils.test.ts` around lines 70 - 84, Extend the getFilesetRoute tests to cover the FILESET_DETAILS_ENABLED-enabled branch for both bare and already-namespaced references, including an options.tab value. Assert the detail-route URL and normalized entity references while preserving the existing legacy-route coverage.web/packages/studio/src/routes/utils.ts (1)
491-495: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winMake the exported route contract explicit.
getFilesetRouterepeats the inline{ tab?: FilesetDetailTab }shape and infers its public return type. Define oneFilesetRouteOptionsinterface, reuse it in both route helpers, marktabasreadonly, and declare the return type asstring.Proposed refactor
+interface FilesetRouteOptions { + readonly tab?: FilesetDetailTab; +} ... - options?: { tab?: FilesetDetailTab } + options?: FilesetRouteOptions -) => { +): string => {As per coding guidelines, prefer
interfacefor object shapes and contracts, usereadonlyfor immutable properties, and use explicit return types for public APIs.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/packages/studio/src/routes/utils.ts` around lines 491 - 495, Update getFilesetRoute and the other fileset route helper to use a shared exported FilesetRouteOptions interface instead of inline option shapes; define its tab property as readonly and optional, and explicitly declare getFilesetRoute’s public return type as string.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@web/packages/studio/src/routes/utils.test.ts`:
- Around line 70-84: Extend the getFilesetRoute tests to cover the
FILESET_DETAILS_ENABLED-enabled branch for both bare and already-namespaced
references, including an options.tab value. Assert the detail-route URL and
normalized entity references while preserving the existing legacy-route
coverage.
In `@web/packages/studio/src/routes/utils.ts`:
- Around line 491-495: Update getFilesetRoute and the other fileset route helper
to use a shared exported FilesetRouteOptions interface instead of inline option
shapes; define its tab property as readonly and optional, and explicitly declare
getFilesetRoute’s public return type as string.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c09b679f-93af-4abb-8e4d-9be459f17872
📒 Files selected for processing (5)
web/packages/studio/src/components/dataViews/AgentEvaluationsDataView/index.tsxweb/packages/studio/src/components/evaluation/Jobs/DetailsPanel.tsxweb/packages/studio/src/routes/agents/AgentEvaluationsRoute/AgentEvaluationDetailRoute.tsxweb/packages/studio/src/routes/utils.test.tsweb/packages/studio/src/routes/utils.ts
Contributor
|
walston
approved these changes
Aug 10, 2026
htolentino-nvidia
deleted the
fix-eval-config-fileset-link-404/htolentino
branch
August 10, 2026 17:17
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://nvbugspro.nvidia.com/bug/6581177
Summary by CodeRabbit
Bug Fixes
Tests