fix(studio): Address pnpm audit and latest node versions - #1042
Merged
Conversation
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
Contributor
📝 WalkthroughWalkthroughThe changes align Node.js and pnpm versions across project configuration and setup guidance. They also update workspace dependency overrides, the ChangesToolchain and dependency updates
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Makefile`:
- Line 236: Update the Node.js bootstrap version documented in README.md from
22.18.0 to 22.23.2, matching the version shown by the Makefile command and the
web/package.json configuration.
In `@web/package.json`:
- Around line 57-60: Add the requested scripts across all affected manifests:
add test:ci as vitest run --coverage to web/package.json,
web/packages/scripts/package.json, and web/packages/storybook/package.json; add
typecheck as tsc --noEmit to web/package.json and
web/packages/storybook/package.json; add the coverage script to
web/packages/sdk/package.json; and remove --noErrorTruncation from the typecheck
scripts in web/packages/scripts/package.json and
web/packages/studio/package.json. The anchor web/package.json lines 57-60 and
sibling web/packages/studio/package.json line 118 require these manifest
updates.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 51a6e44b-8ff8-4ed1-96b1-be1a62bf8478
⛔ Files ignored due to path filters (1)
web/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
Makefileweb/.nvmrcweb/package.jsonweb/packages/studio/package.jsonweb/pnpm-workspace.yaml
Contributor
|
Follow-up to the toolchain bump: README still documented 22.18.0 while the Makefile hint, web/.nvmrc, and web/package.json engines all moved to 22.23.2. Signed-off-by: Sean Teramae <steramae@nvidia.com>
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 82: Update the toolchain requirements in README.md to state Node.js
>=22.23.2 <23 instead of 22.18.x, and add the documented pnpm requirement
>=10.34.5. Keep the existing bootstrap guidance unchanged, noting that pnpm env
use --global 22.23.2 only changes Node.js.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 750f34db-390a-4660-93d4-f61da777eb18
📒 Files selected for processing (1)
README.md
…json README prerequisites still listed Node 22.18.x and omitted a pnpm floor. Also updates the setup guide and AGENTS.md, which carried the same stale 22.18.0 bootstrap version. Release-notes docs are left as-is since they record what each shipped release required. Signed-off-by: Sean Teramae <steramae@nvidia.com>
Contributor
nakolean
approved these changes
Aug 3, 2026
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@AGENTS.md`:
- Line 245: Update AGENTS.md at line 245 to state the exact Node.js range
>=22.23.2 <23 and pnpm range >=10.34.5 instead of 22.23.x and the indirect pnpm
reference; update docs/get-started/setup.mdx at line 16 to add pnpm >=10.34.5 to
the source-checkout prerequisites.
In `@docs/get-started/setup.mdx`:
- Line 53: Update both Studio recovery instructions in
docs/get-started/setup.mdx at lines 53-53 and 247-247 to add a step that
installs or validates pnpm version 10.34.5 or newer before rerunning make
bootstrap-studio; retain the existing Node.js setup guidance and apply the same
pnpm requirement at both locations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 2090089e-1034-457f-9f63-2b3e8eb3676f
📒 Files selected for processing (3)
AGENTS.mdREADME.mddocs/get-started/setup.mdx
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sean Teramae steramae@nvidia.com
Summary by CodeRabbit