feat: add gpu mem and util logging to wandb/tensorboard#37
Merged
Conversation
0952265 to
9c8cf81
Compare
parthchadha
reviewed
Mar 23, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Co-authored-by: Parth Chadha <pchadha@nvidia.com> Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
2fe7bb6 to
f40499e
Compare
Signed-off-by: Terry Kong <terryk@nvidia.com>
avialable on the head node) Signed-off-by: Terry Kong <terryk@nvidia.com>
parthchadha
approved these changes
Mar 24, 2025
Collaborator
Author
|
Functional tests need a followup PR to fix #41 Running them manually, will merge once they pass |
KiddoZhu
pushed a commit
that referenced
this pull request
May 6, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Parth Chadha <pchadha@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
setup()so we can log memory/util ealier (previously the logging started after vLLM workers were spun up)Falseso it matches grpo and doesn't error if someone doesn't setWANDB_API_KEYIssues
List issues that this PR closes (syntax):
Closes #35
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information