ci: tests now run with HF_DATASETS_CACHE to speed up e2e time#41
Merged
ci: tests now run with HF_DATASETS_CACHE to speed up e2e time#41
Conversation
terrykong
changed the title
terrykong
changed the title
4 tasks
terrykong
force-pushed
the
functional-fix
branch
from
8ba7c0e to
d49f778
Compare
Signed-off-by: Terry Kong <terryk@nvidia.com> now run grpo Signed-off-by: Terry Kong <terryk@nvidia.com> more args Signed-off-by: Terry Kong <terryk@nvidia.com> trying again Signed-off-by: Terry Kong <terryk@nvidia.com> trying with ultra short uv cache dirname Signed-off-by: Terry Kong <terryk@nvidia.com> lower val batches b/c took 10min to do val Signed-off-by: Terry Kong <terryk@nvidia.com> give this a shot Signed-off-by: Terry Kong <terryk@nvidia.com> With all datasets downloaded, re-enable functional tests Signed-off-by: Terry Kong <terryk@nvidia.com> lint Signed-off-by: Terry Kong <terryk@nvidia.com> fix some stuff Signed-off-by: Terry Kong <terryk@nvidia.com>
terrykong
force-pushed
the
functional-fix
branch
from
d49f778 to
5aa0dde
Compare
Signed-off-by: Terry Kong <terryk@nvidia.com>
terrykong
changed the title
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
parthchadha
approved these changes
Mar 24, 2025
KiddoZhu
pushed a commit
that referenced
this pull request
May 6, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Previously our functional tests timedout b/c it had to fetch all the datasets. This change adds HF_DATASETS_CACHE to avoid downloading squad/openmath over and over.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information