Conversation
d9efb6c to
f99d7d6
Compare
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
d0f9478 to
8b7a88e
Compare
Collaborator
Author
parthchadha
approved these changes
Mar 26, 2025
yfw
pushed a commit
that referenced
this pull request
Apr 2, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
KiddoZhu
pushed a commit
that referenced
this pull request
May 6, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Tracking metrics in unit tests
Unit tests may also log metrics to a fixture. The fixture is called
trackerand has the following API:Including the
trackerfixture also tracks the elapsed time for the test implicitly.Here is an example test:
Which would produce this file in
tests/unit/unit_results.json:{ "exit_status": 0, "git_commit": "f1062bd3fd95fc64443e2d9ee4a35fc654ba897e", "start_time": "2025-03-24 23:34:12", "metrics": { "test_hf_ray_policy::test_hf_policy_generation": { "avg_prob_mult_error": 1.0000039339065552, "mean_lps": -1.5399343967437744, "_elapsed": 17.323044061660767 } }, "gpu_types": [ "NVIDIA H100 80GB HBM3" ], "coverage": 24.55897613282601 }:::{tip}
Past unit test results are logged in
tests/unit/unit_results/. These are helpful to view trends over time and commits.Here's an example
jqcommand to view trends::::