chore(beep boop 🤖): Bump uv.lock (main, mcore-main) (2026-04-16) - #3352
Conversation
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
/ok to test c85192e |
📝 WalkthroughWalkthroughThis PR updates the Megatron-LM submodule pointer in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.main.commit:
- Line 1: The submodule pointer in .main.commit references a non-existent
upstream commit 23265d2db37efa883b3983bce321c631898822f3; fix this by either (A)
pushing that commit to the upstream Megatron-LM repository so the pointer is
valid, or (B) updating the submodule to point at an existing upstream commit and
committing the new SHA into .main.commit (ensure the submodule update was
executed against the upstream remote and that the new SHA is the actual upstream
commit id before committing the changed .main.commit).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 19b054a4-d398-4e47-9ce5-11a093d099d0
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
.main.commit3rdparty/Megatron-LM
| @@ -1 +1 @@ | |||
| c2d1a8f7e508f216b4974b10c7cbf6c05f97da3d | |||
| 23265d2db37efa883b3983bce321c631898822f3 | |||
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify .main.commit matches the actual submodule commit
# Get the commit from .main.commit
MAIN_COMMIT=$(cat .main.commit | tr -d '[:space:]')
echo "=== .main.commit contains: $MAIN_COMMIT ==="
# Get the actual submodule commit
SUBMODULE_COMMIT=$(git ls-tree HEAD 3rdparty/Megatron-LM | awk '{print $3}')
echo "=== Submodule commit is: $SUBMODULE_COMMIT ==="
# Compare
if [ "$MAIN_COMMIT" = "$SUBMODULE_COMMIT" ]; then
echo "✓ .main.commit matches submodule"
else
echo "✗ MISMATCH: .main.commit ($MAIN_COMMIT) != submodule ($SUBMODULE_COMMIT)"
exit 1
fi
# Verify upstream commit exists
echo "=== Checking if commit exists in upstream Megatron-LM ==="
cd 3rdparty/Megatron-LM
if git cat-file -e "$SUBMODULE_COMMIT^{commit}" 2>/dev/null; then
echo "✓ Commit $SUBMODULE_COMMIT exists in upstream"
git log -1 --oneline "$SUBMODULE_COMMIT"
else
echo "✗ Commit $SUBMODULE_COMMIT not found in upstream"
exit 1
fiRepository: NVIDIA-NeMo/Megatron-Bridge
Length of output: 375
Fix submodule state: upstream commit 23265d2db37efa883b3983bce321c631898822f3 does not exist.
The .main.commit file correctly matches the submodule pointer, but the referenced commit does not exist in the upstream Megatron-LM repository. Per the project guidelines, submodule changes must come from upstream. Either:
- Push the commit to the upstream Megatron-LM repository, or
- Update the submodule to point to an existing upstream commit
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.main.commit at line 1, The submodule pointer in .main.commit references a
non-existent upstream commit 23265d2db37efa883b3983bce321c631898822f3; fix this
by either (A) pushing that commit to the upstream Megatron-LM repository so the
pointer is valid, or (B) updating the submodule to point at an existing upstream
commit and committing the new SHA into .main.commit (ensure the submodule update
was executed against the upstream remote and that the new SHA is the actual
upstream commit id before committing the changed .main.commit).
…VIDIA-NeMo#3352) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: dimapihtar <37850217+dimapihtar@users.noreply.github.com> Signed-off-by: Vasudevan Rengasamy <vrengasamy@nvidia.com>
🚀 PR to bump
uv.lockinmain.🤖 This PR will be merged automatically once CI passes.
Summary by CodeRabbit