Skip to content

chore(beep boop 🤖): Bump uv.lock (main, mcore-main) (2026-04-16) - #3352

Merged
yaoyu-33 merged 1 commit into
mainfrom
bump-ci-container-2026-04-16-main-main
Apr 16, 2026
Merged

chore(beep boop 🤖): Bump uv.lock (main, mcore-main) (2026-04-16)#3352
yaoyu-33 merged 1 commit into
mainfrom
bump-ci-container-2026-04-16-main-main

Conversation

@svcnvidia-nemo-ci

@svcnvidia-nemo-ci svcnvidia-nemo-ci commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

🚀 PR to bump uv.lock in main.

🤖 This PR will be merged automatically once CI passes.

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies to latest upstream versions.

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor Author

/ok to test c85192e

@copy-pr-bot

copy-pr-bot Bot commented Apr 16, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This PR updates the Megatron-LM submodule pointer in the 3rdparty/Megatron-LM directory and the corresponding commit identifier in .main.commit from c2d1a8f7e508f216b4974b10c7cbf6c05f97da3d to 23265d2db37efa883b3983bce321c631898822f3. No functional code changes are introduced.

Changes

Cohort / File(s) Summary
Megatron-LM Submodule Update
.main.commit, 3rdparty/Megatron-LM
Submodule commit pointer bumped to upstream commit 23265d2db37efa883b3983bce321c631898822f3.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Megatron-Bridge#3335: Updates the same Megatron-LM submodule pointer, advancing from the commit this PR updates from.
  • Megatron-Bridge#3016: Updates the same submodule reference to different upstream commits.
  • Megatron-Bridge#3210: Performs the same kind of submodule pointer update.

Suggested reviewers

  • yaoyu-33
  • ko3n1g
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions bumping 'uv.lock' but the actual changes only update '.main.commit' and a submodule reference, not the lock file. Update the title to accurately reflect that the PR updates '.main.commit' and the Megatron-LM submodule, not 'uv.lock'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed PR contains only minor dependency lock file and submodule pointer updates with no logic, configuration, or API changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-ci-container-2026-04-16-main-main

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.main.commit:
- Line 1: The submodule pointer in .main.commit references a non-existent
upstream commit 23265d2db37efa883b3983bce321c631898822f3; fix this by either (A)
pushing that commit to the upstream Megatron-LM repository so the pointer is
valid, or (B) updating the submodule to point at an existing upstream commit and
committing the new SHA into .main.commit (ensure the submodule update was
executed against the upstream remote and that the new SHA is the actual upstream
commit id before committing the changed .main.commit).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 19b054a4-d398-4e47-9ce5-11a093d099d0

📥 Commits

Reviewing files that changed from the base of the PR and between b8b13d3 and c85192e.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .main.commit
  • 3rdparty/Megatron-LM

Comment thread .main.commit
@@ -1 +1 @@
c2d1a8f7e508f216b4974b10c7cbf6c05f97da3d
23265d2db37efa883b3983bce321c631898822f3

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify .main.commit matches the actual submodule commit

# Get the commit from .main.commit
MAIN_COMMIT=$(cat .main.commit | tr -d '[:space:]')
echo "=== .main.commit contains: $MAIN_COMMIT ==="

# Get the actual submodule commit
SUBMODULE_COMMIT=$(git ls-tree HEAD 3rdparty/Megatron-LM | awk '{print $3}')
echo "=== Submodule commit is: $SUBMODULE_COMMIT ==="

# Compare
if [ "$MAIN_COMMIT" = "$SUBMODULE_COMMIT" ]; then
    echo "✓ .main.commit matches submodule"
else
    echo "✗ MISMATCH: .main.commit ($MAIN_COMMIT) != submodule ($SUBMODULE_COMMIT)"
    exit 1
fi

# Verify upstream commit exists
echo "=== Checking if commit exists in upstream Megatron-LM ==="
cd 3rdparty/Megatron-LM
if git cat-file -e "$SUBMODULE_COMMIT^{commit}" 2>/dev/null; then
    echo "✓ Commit $SUBMODULE_COMMIT exists in upstream"
    git log -1 --oneline "$SUBMODULE_COMMIT"
else
    echo "✗ Commit $SUBMODULE_COMMIT not found in upstream"
    exit 1
fi

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 375


Fix submodule state: upstream commit 23265d2db37efa883b3983bce321c631898822f3 does not exist.

The .main.commit file correctly matches the submodule pointer, but the referenced commit does not exist in the upstream Megatron-LM repository. Per the project guidelines, submodule changes must come from upstream. Either:

  • Push the commit to the upstream Megatron-LM repository, or
  • Update the submodule to point to an existing upstream commit
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.main.commit at line 1, The submodule pointer in .main.commit references a
non-existent upstream commit 23265d2db37efa883b3983bce321c631898822f3; fix this
by either (A) pushing that commit to the upstream Megatron-LM repository so the
pointer is valid, or (B) updating the submodule to point at an existing upstream
commit and committing the new SHA into .main.commit (ensure the submodule update
was executed against the upstream remote and that the new SHA is the actual
upstream commit id before committing the changed .main.commit).

@yaoyu-33 yaoyu-33 added ci CI, automation, test queue, or workflow infrastructure work area:build Dependencies, packaging, images, and environment setup needs-review PR is ready for code review and waiting on a reviewer and removed needs-review PR is ready for code review and waiting on a reviewer labels Apr 16, 2026
@yaoyu-33
yaoyu-33 enabled auto-merge (squash) April 16, 2026 18:45
@yaoyu-33
yaoyu-33 merged commit e1c80ae into main Apr 16, 2026
206 of 217 checks passed
@yaoyu-33
yaoyu-33 deleted the bump-ci-container-2026-04-16-main-main branch April 16, 2026 18:45
vasunvidia pushed a commit to vasunvidia/Megatron-Bridge that referenced this pull request Jun 10, 2026
…VIDIA-NeMo#3352)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: dimapihtar <37850217+dimapihtar@users.noreply.github.com>
Signed-off-by: Vasudevan Rengasamy <vrengasamy@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build Dependencies, packaging, images, and environment setup ci CI, automation, test queue, or workflow infrastructure work full-test-suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants