Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .main.commit
Original file line number Diff line number Diff line change
@@ -1 +1 @@
c2d1a8f7e508f216b4974b10c7cbf6c05f97da3d
23265d2db37efa883b3983bce321c631898822f3

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify .main.commit matches the actual submodule commit

# Get the commit from .main.commit
MAIN_COMMIT=$(cat .main.commit | tr -d '[:space:]')
echo "=== .main.commit contains: $MAIN_COMMIT ==="

# Get the actual submodule commit
SUBMODULE_COMMIT=$(git ls-tree HEAD 3rdparty/Megatron-LM | awk '{print $3}')
echo "=== Submodule commit is: $SUBMODULE_COMMIT ==="

# Compare
if [ "$MAIN_COMMIT" = "$SUBMODULE_COMMIT" ]; then
    echo "✓ .main.commit matches submodule"
else
    echo "✗ MISMATCH: .main.commit ($MAIN_COMMIT) != submodule ($SUBMODULE_COMMIT)"
    exit 1
fi

# Verify upstream commit exists
echo "=== Checking if commit exists in upstream Megatron-LM ==="
cd 3rdparty/Megatron-LM
if git cat-file -e "$SUBMODULE_COMMIT^{commit}" 2>/dev/null; then
    echo "✓ Commit $SUBMODULE_COMMIT exists in upstream"
    git log -1 --oneline "$SUBMODULE_COMMIT"
else
    echo "✗ Commit $SUBMODULE_COMMIT not found in upstream"
    exit 1
fi

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 375


Fix submodule state: upstream commit 23265d2db37efa883b3983bce321c631898822f3 does not exist.

The .main.commit file correctly matches the submodule pointer, but the referenced commit does not exist in the upstream Megatron-LM repository. Per the project guidelines, submodule changes must come from upstream. Either:

  • Push the commit to the upstream Megatron-LM repository, or
  • Update the submodule to point to an existing upstream commit
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.main.commit at line 1, The submodule pointer in .main.commit references a
non-existent upstream commit 23265d2db37efa883b3983bce321c631898822f3; fix this
by either (A) pushing that commit to the upstream Megatron-LM repository so the
pointer is valid, or (B) updating the submodule to point at an existing upstream
commit and committing the new SHA into .main.commit (ensure the submodule update
was executed against the upstream remote and that the new SHA is the actual
upstream commit id before committing the changed .main.commit).

Loading
Loading