chore(beep boop 🤖): Bump uv.lock (main, mcore-main) (2026-04-18) - #3403
Merged
Conversation
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Contributor
Author
|
/ok to test 0ac9efa |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe changes update the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Mcore added a validation that raises ValueError when the layer spec sets q_layernorm/k_layernorm but qk_layernorm is disabled in TransformerConfig. Gemma3 uses QK layernorm (q_norm/k_norm in HF), so set qk_layernorm=True in Gemma3ModelProvider. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
…dation" This reverts commit ab6135d.
…idation
Mcore e15ec3c04 ("Add QK layernorm support for dot-product attention in
MambaModel") added a consistency check: if qk_layernorm is False, the
spec must not set q_layernorm/k_layernorm. Previously mcore silently
used whatever the spec provided regardless of the config flag.
Two fixes:
- Set qk_layernorm=True in Gemma3ModelProvider (Gemma3 uses QK norm)
- Make gemma3_layer_spec() respect config.qk_layernorm so the spec and
config stay consistent
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Contributor
|
/ok to test a2fcee7 |
Same mcore validation fix as Gemma3 (e15ec3c04): mcore now requires config.qk_layernorm=True when the spec sets q_layernorm/k_layernorm. - Flux: add qk_layernorm=True to FluxProvider (single blocks use FluxSingleAttention which extends SelfAttention) - Wan: add qk_layernorm=True to WanModelProvider (DiTSelfAttention extends SelfAttention) - MiniMax M2: change qk_layernorm from False to True in the bridge. The old workaround (False to avoid default TENorm) is no longer needed — mcore now uses the spec's FullDimQNorm/FullDimKNorm when qk_layernorm=True and the spec provides overrides. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Contributor
|
/ok to test 774dcae |
Align test assertion with 774dcae which enabled qk_layernorm for MiniMax M2. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Contributor
|
/ok to test 07aa2f3 |
ko3n1g
approved these changes
Apr 20, 2026
vasunvidia
pushed a commit
to vasunvidia/Megatron-Bridge
that referenced
this pull request
Jun 10, 2026
…VIDIA-NeMo#3403) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com> Co-authored-by: dimapihtar <37850217+dimapihtar@users.noreply.github.com> Co-authored-by: yaoyu-33 <yaoyu.094@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Vasudevan Rengasamy <vrengasamy@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 PR to bump
uv.lockinmain.🤖 This PR will be merged automatically once CI passes.
Summary by CodeRabbit