Skip to content

chore(beep boop 🤖): Bump uv.lock (main, mcore-main) (2026-04-08) - #3210

Merged
yaoyu-33 merged 3 commits into
mainfrom
bump-ci-container-2026-04-08-main-main
Apr 8, 2026
Merged

chore(beep boop 🤖): Bump uv.lock (main, mcore-main) (2026-04-08)#3210
yaoyu-33 merged 3 commits into
mainfrom
bump-ci-container-2026-04-08-main-main

Conversation

@svcnvidia-nemo-ci

@svcnvidia-nemo-ci svcnvidia-nemo-ci commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

🚀 PR to bump uv.lock in main.

🤖 This PR will be merged automatically once CI passes.

Summary by CodeRabbit

  • Chores
    • Updated internal dependency references.

Note: This release contains no user-facing feature changes or bug fixes. The updates are internal maintenance-related adjustments.

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor Author

/ok to test 42ad86b

@copy-pr-bot

copy-pr-bot Bot commented Apr 8, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This PR updates the Megatron-LM submodule reference to a new commit hash. The .main.commit file and the 3rdparty/Megatron-LM submodule pointer are both updated from commit 17a67b9a97fb11a75933fd7f76ad76e1ac98a53d to 8cf6b355a7bd8fe6abe39bc7596bd3c1cb92bee8.

Changes

Cohort / File(s) Summary
Megatron-LM Submodule Update
.main.commit, 3rdparty/Megatron-LM
Submodule pointer updated to a new commit version (8cf6b355a7bd8fe6abe39bc7596bd3c1cb92bee8).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • PR #2813: Updates the Megatron-LM submodule pointer (.main.commit) to a different commit hash.
  • PR #3016: Directly updates the same .main.commit and 3rdparty/Megatron-LM submodule reference.
  • PR #2873: Changes both .main.commit and 3rdparty/Megatron-LM submodule pointer to different target commits.

Suggested reviewers

  • yaoyu-33
  • maanug-nv
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions bumping 'uv.lock' but the actual changes are updates to '.main.commit' and 'Megatron-LM' submodule, not the lock file. Update the title to accurately reflect the actual changes, such as 'chore: Update Megatron-LM submodule and .main.commit' or similar to match the file modifications.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed This PR contains only minor changes—a submodule pointer update with +1/-1 lines. No major modifications, new features, or breaking changes are present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-ci-container-2026-04-08-main-main

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.main.commit:
- Line 1: The PR title incorrectly says "Bump `uv.lock`" while the change
actually updates the Megatron-LM submodule reference in .main.commit (commit
8cf6b355a7bd8fe6abe39bc7596bd3c1cb92bee8); update the PR title and commit
message to accurately describe the change (e.g., "Bump Megatron-LM submodule to
8cf6b35") or, if the intent was to bump uv.lock, revert this submodule change
and make the uv.lock update instead so PR title and .main.commit stay
consistent.
- Line 1: The .main.commit entry points to a non-existent Megatron-LM commit
(8cf6b355a7bd8fe6abe39bc7596bd3c1cb92bee8), which will break the
3rdparty/Megatron-LM submodule; verify whether that commit was pushed to the
Megatron-LM repo or the hash is mistyped, then update the submodule pointer and
.main.commit to a valid commit: either push the missing commit to the
Megatron-LM remote or replace the hash in .main.commit and run git submodule
update --init --recursive (and commit the corrected submodule reference) so
3rdparty/Megatron-LM points to an existing commit.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a74486f5-0b92-4ae1-a993-360b78f1a5e3

📥 Commits

Reviewing files that changed from the base of the PR and between 07c9920 and 42ad86b.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .main.commit
  • 3rdparty/Megatron-LM

Comment thread .main.commit
@@ -1 +1 @@
17a67b9a97fb11a75933fd7f76ad76e1ac98a53d No newline at end of file
8cf6b355a7bd8fe6abe39bc7596bd3c1cb92bee8

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Note: PR title mentions uv.lock but changes are to submodule reference.

The PR title states "Bump uv.lock" but the actual changes update the Megatron-LM submodule reference in .main.commit. This may cause confusion when reviewing the PR history.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.main.commit at line 1, The PR title incorrectly says "Bump `uv.lock`" while
the change actually updates the Megatron-LM submodule reference in .main.commit
(commit 8cf6b355a7bd8fe6abe39bc7596bd3c1cb92bee8); update the PR title and
commit message to accurately describe the change (e.g., "Bump Megatron-LM
submodule to 8cf6b35") or, if the intent was to bump uv.lock, revert this
submodule change and make the uv.lock update instead so PR title and
.main.commit stay consistent.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify the commit exists in Megatron-LM and check submodule consistency

# Check if the commit exists in the submodule
cd 3rdparty/Megatron-LM
if git cat-file -e 8cf6b355a7bd8fe6abe39bc7596bd3c1cb92bee8 2>/dev/null; then
    echo "✓ Commit exists in Megatron-LM repository"
    git log -1 --oneline 8cf6b355a7bd8fe6abe39bc7596bd3c1cb92bee8
else
    echo "✗ Commit not found in Megatron-LM repository"
fi
cd ../..

# Verify submodule pointer matches .main.commit
SUBMODULE_HASH=$(git ls-tree HEAD 3rdparty/Megatron-LM | awk '{print $3}')
MAIN_COMMIT_HASH=$(cat .main.commit | tr -d '[:space:]')

echo ""
echo "Submodule pointer: $SUBMODULE_HASH"
echo ".main.commit hash:  $MAIN_COMMIT_HASH"

if [ "$SUBMODULE_HASH" = "$MAIN_COMMIT_HASH" ]; then
    echo "✓ Submodule pointer matches .main.commit"
else
    echo "✗ Mismatch between submodule pointer and .main.commit"
fi

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 278


Commit hash does not exist in the Megatron-LM repository—this will break the submodule.

The commit 8cf6b355a7bd8fe6abe39bc7596bd3c1cb92bee8 is not found in the 3rdparty/Megatron-LM submodule, despite the submodule pointer and .main.commit file both referencing it consistently. This means users cloning this repository will fail to fetch the submodule.

Verify that:

  1. The commit has been pushed to the Megatron-LM repository, or
  2. The commit hash is correct
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.main.commit at line 1, The .main.commit entry points to a non-existent
Megatron-LM commit (8cf6b355a7bd8fe6abe39bc7596bd3c1cb92bee8), which will break
the 3rdparty/Megatron-LM submodule; verify whether that commit was pushed to the
Megatron-LM repo or the hash is mistyped, then update the submodule pointer and
.main.commit to a valid commit: either push the missing commit to the
Megatron-LM remote or replace the hash in .main.commit and run git submodule
update --init --recursive (and commit the corrected submodule reference) so
3rdparty/Megatron-LM points to an existing commit.

…heckpoint layout

Real GPT-OSS checkpoints store down_proj as [num_experts, hidden, intermediate]
but HF model init produces [num_experts, intermediate, hidden]. After PR #3162
removed the import-side transpose, the CI toy models need to match the real layout.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
@yaoyu-33

yaoyu-33 commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

/ok to test af7d51b

GPT-OSS down_proj is intentionally transposed on export (megatron_to_hf)
per PR #3162. Align shapes before torch.allclose to avoid RuntimeError
when the exported param has swapped dimensions vs the original.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
@yaoyu-33
yaoyu-33 force-pushed the bump-ci-container-2026-04-08-main-main branch from 52c6e7f to af009ac Compare April 8, 2026 18:04
@yaoyu-33

yaoyu-33 commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

/ok to test af009ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants