Skip to content

chore(beep boop 🤖): Bump uv.lock (r0.4.0, mcore-core_r0.17.0) (2026-04-16) - #3353

Closed
svcnvidia-nemo-ci wants to merge 2 commits into
r0.4.0from
bump-ci-container-2026-04-16-r0.4.0-core_r0.17.0
Closed

chore(beep boop 🤖): Bump uv.lock (r0.4.0, mcore-core_r0.17.0) (2026-04-16)#3353
svcnvidia-nemo-ci wants to merge 2 commits into
r0.4.0from
bump-ci-container-2026-04-16-r0.4.0-core_r0.17.0

Conversation

@svcnvidia-nemo-ci

@svcnvidia-nemo-ci svcnvidia-nemo-ci commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

🚀 PR to bump uv.lock in r0.4.0.

🤖 This PR will be merged automatically once CI passes.

Summary by CodeRabbit

  • Chores
    • Updated internal module references and version pointers for dependency management.

…-04-16)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor Author

/ok to test bbdb5b1

@copy-pr-bot

copy-pr-bot Bot commented Apr 16, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Updated the stored Megatron-LM commit reference in .main.commit and the corresponding git submodule pointer in 3rdparty/Megatron-LM from commit d7288711ba278d160d2a5a22c099915c9fe1395c to 9539a12e1b04a68423f57b3eb41d6125161dca24.

Changes

Cohort / File(s) Summary
Megatron-LM Submodule Update
.main.commit, 3rdparty/Megatron-LM
Updated both files to reference the same new commit hash for the Megatron-LM external dependency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • ko3n1g
  • yaoyu-33
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions bumping 'uv.lock' but the actual changes only update commit identifiers in '.main.commit' and a Megatron-LM submodule pointer, not the uv.lock file. Update the title to accurately reflect the actual changes, such as 'chore: Update Megatron-LM submodule and main commit pointer' or similar.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed PR contains only minor dependency management changes (uv.lock, submodule pointers, commit identifiers) labeled as chore maintenance with minimal code review effort and no impact on core functionality.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-ci-container-2026-04-16-r0.4.0-core_r0.17.0

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@3rdparty/Megatron-LM`:
- Line 1: The submodule pointer for 3rdparty/Megatron-LM is referencing a
non-existent commit (9539a12e1b04a68423f57b3eb41d6125161dca24); fix by verifying
and updating the submodule reference: check .gitmodules for the Megatron-LM
remote URL, ensure it matches the upstream NVIDIA/Megatron-LM repo, run git
submodule sync && git submodule update --init --remote 3rdparty/Megatron-LM to
fetch reachable commits, then reset the submodule pointer to a valid commit or
branch (replace the bad hash in the superproject commit) and commit that update
so the pointer references an existing upstream commit.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d48c7c4e-5328-4d71-b896-7eba7eae466b

📥 Commits

Reviewing files that changed from the base of the PR and between f4d10a3 and bbdb5b1.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .main.commit
  • 3rdparty/Megatron-LM

Comment thread 3rdparty/Megatron-LM
@@ -1 +1 @@
Subproject commit d7288711ba278d160d2a5a22c099915c9fe1395c
Subproject commit 9539a12e1b04a68423f57b3eb41d6125161dca24

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify the Megatron-LM submodule commit exists upstream and examine changes

# Navigate to the submodule directory
cd 3rdparty/Megatron-LM || exit 1

# Fetch latest from upstream to ensure we have the commit
git fetch origin

# Verify the new commit exists
echo "=== Verifying new commit exists ==="
if git cat-file -t 9539a12e1b04a68423f57b3eb41d6125161dca24 2>/dev/null; then
    echo "✓ Commit 9539a12e1b04a68423f57b3eb41d6125161dca24 exists"
else
    echo "✗ Commit 9539a12e1b04a68423f57b3eb41d6125161dca24 NOT FOUND"
    exit 1
fi

# Show commit message for the new commit
echo -e "\n=== New commit details ==="
git log -1 --oneline 9539a12e1b04a68423f57b3eb41d6125161dca24

# Show summary of changes between old and new commits
echo -e "\n=== Changes between commits ==="
git log --oneline d7288711ba278d160d2a5a22c099915c9fe1395c..9539a12e1b04a68423f57b3eb41d6125161dca24

# Show files changed
echo -e "\n=== Files changed ==="
git diff --stat d7288711ba278d160d2a5a22c099915c9fe1395c..9539a12e1b04a68423f57b3eb41d6125161dca24

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 166


The submodule pointer commit cannot be verified — this will cause build failures.

The commit 9539a12e1b04a68423f57b3eb41d6125161dca24 could not be found after fetching from the upstream repository. This indicates either:

  • The commit hash is incorrect or contains a typo
  • The commit doesn't exist in the upstream Megatron-LM repository
  • The submodule remote URL is misconfigured

Verify that the new commit hash 9539a12e1b04a68423f57b3eb41d6125161dca24 exists in the upstream NVIDIA/Megatron-LM repository and is reachable from the branch being tracked.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@3rdparty/Megatron-LM` at line 1, The submodule pointer for
3rdparty/Megatron-LM is referencing a non-existent commit
(9539a12e1b04a68423f57b3eb41d6125161dca24); fix by verifying and updating the
submodule reference: check .gitmodules for the Megatron-LM remote URL, ensure it
matches the upstream NVIDIA/Megatron-LM repo, run git submodule sync && git
submodule update --init --remote 3rdparty/Megatron-LM to fetch reachable
commits, then reset the submodule pointer to a valid commit or branch (replace
the bad hash in the superproject commit) and commit that update so the pointer
references an existing upstream commit.

@yaoyu-33 yaoyu-33 added ci CI, automation, test queue, or workflow infrastructure work area:build Dependencies, packaging, images, and environment setup needs-review PR is ready for code review and waiting on a reviewer labels Apr 16, 2026
@ko3n1g

ko3n1g commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Apr 17, 2026

Copy link
Copy Markdown

/ok to test

@ko3n1g, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@ko3n1g

ko3n1g commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Apr 17, 2026

Copy link
Copy Markdown

/ok to test

@ko3n1g, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@ko3n1g

ko3n1g commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

/ok to test aa0ace4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build Dependencies, packaging, images, and environment setup ci CI, automation, test queue, or workflow infrastructure work full-test-suite needs-review PR is ready for code review and waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants