chore(beep boop 🤖): Bump uv.lock (r0.4.0, mcore-core_r0.17.0) (2026-04-10) - #3266
chore(beep boop 🤖): Bump uv.lock (r0.4.0, mcore-core_r0.17.0) (2026-04-10)#3266svcnvidia-nemo-ci wants to merge 1 commit into
uv.lock (r0.4.0, mcore-core_r0.17.0) (2026-04-10)#3266Conversation
…-04-10) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
/ok to test be52248 |
📝 WalkthroughWalkthroughThe PR updates the recorded commit identifier for the Megatron-LM submodule from one hash to another, reflected in both the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.main.commit:
- Line 1: The .main.commit entry currently contains the commit hash
d7288711ba278d160d2a5a22c099915c9fe1395c which is from NVIDIA/Megatron-LM PR
`#4237` and not a Megatron-Core release; verify the intended Megatron-Core
revision and replace the value in .main.commit with the correct Megatron-Core
commit hash (or revert this change if the submodule update was accidental),
ensuring the new hash actually exists in the Megatron-Core repository and pins
the desired release/tag; update the commit message to reflect the correct
submodule target if you change the hash.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3f76d1e0-f791-42ba-8561-555f30c12e1e
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
.main.commit3rdparty/Megatron-LM
| @@ -1 +1 @@ | |||
| c506380bda61c6788853ed9e08e0fb0d6cbfb4b4 | |||
| d7288711ba278d160d2a5a22c099915c9fe1395c | |||
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify the commit exists in Megatron-LM and check its tags/branches
# Check if the commit exists in the submodule
cd 3rdparty/Megatron-LM || exit 1
# Verify commit exists
if ! git cat-file -e d7288711ba278d160d2a5a22c099915c9fe1395c 2>/dev/null; then
echo "ERROR: Commit d7288711ba278d160d2a5a22c099915c9fe1395c not found"
exit 1
fi
# Show commit info
echo "=== Commit Information ==="
git log -1 --oneline d7288711ba278d160d2a5a22c099915c9fe1395c
# Check which tags contain this commit
echo -e "\n=== Tags containing this commit ==="
git tag --contains d7288711ba278d160d2a5a22c099915c9fe1395c | grep -i "core_r0.17.0" || echo "No matching tags found"
# Check which branches contain this commit
echo -e "\n=== Branches containing this commit ==="
git branch -r --contains d7288711ba278d160d2a5a22c099915c9fe1395cRepository: NVIDIA-NeMo/Megatron-Bridge
Length of output: 135
🏁 Script executed:
#!/bin/bash
# Check submodule status and try different approaches to verify the commit
echo "=== Git submodule status ==="
git config --file .gitmodules --name-only --get-regexp path | head -20
echo -e "\n=== Current directory contents ==="
ls -la 3rdparty/ 2>/dev/null | head -20
echo -e "\n=== Checking if Megatron-LM is initialized ==="
if [ -d "3rdparty/Megatron-LM/.git" ]; then
echo "Submodule is initialized"
cd 3rdparty/Megatron-LM
echo "Remote URL:"
git config --get remote.origin.url
echo -e "\nChecking remote refs for our commit:"
git ls-remote origin | grep "d7288711ba278d160d2a5a22c099915c9fe1395c" || echo "Commit not in remote heads"
else
echo "Submodule appears not to be initialized as a git repo"
fiRepository: NVIDIA-NeMo/Megatron-Bridge
Length of output: 445
🏁 Script executed:
#!/bin/bash
# Try to understand what this PR is about by checking the file context
echo "=== Contents of .main.commit ==="
cat -n .main.commit
echo -e "\n=== Looking for related files or PR metadata ==="
find . -maxdepth 2 -name "*.commit" -o -name "*commit*" | head -20
echo -e "\n=== Check git status ==="
git status .main.commit 2>/dev/null || echo "Not in git repo"Repository: NVIDIA-NeMo/Megatron-Bridge
Length of output: 348
🏁 Script executed:
#!/bin/bash
# Try to query the Megatron-LM repository directly via git ls-remote
echo "=== Querying NVIDIA-NeMo/Megatron-LM remote repository ==="
git ls-remote https://github.com/NVIDIA-NeMo/Megatron-LM.git | grep "d7288711ba278d160d2a5a22c099915c9fe1395c"
echo -e "\n=== Checking if commit exists in remote (all refs) ==="
git ls-remote https://github.com/NVIDIA-NeMo/Megatron-LM.git | wc -l
echo -e "\n=== Checking for tags related to mcore-core_r0.17.0 ==="
git ls-remote https://github.com/NVIDIA-NeMo/Megatron-LM.git | grep -i "core_r0.17.0"
echo -e "\n=== Checking recent commits in main branch ==="
git ls-remote https://github.com/NVIDIA-NeMo/Megatron-LM.git refs/heads/mainRepository: NVIDIA-NeMo/Megatron-Bridge
Length of output: 743
🌐 Web query:
NVIDIA-NeMo Megatron-LM commit d7288711ba278d160d2a5a22c099915c9fe1395c mcore-core_r0.17.0
💡 Result:
-
Commit:
d7288711ba278d160d2a5a22c099915c9fe1395c(short:d728871) inNVIDIA/Megatron-LM -
Title / PR:
cp: Bump nvrx(PR [diffusion] fix: makeselect_samples_to_packshuffle deterministic across resume #4237) -
What it changes: updates the
nvidia-resiliency-ext(NVRx) git dependency revision inpyproject.toml(and updatesuv.lockaccordingly). [1] -
About
mcore-core_r0.17.0: I could not find any public branch/tag with that exact name inNVIDIA/Megatron-LM(GitHub returns 404 Not Found for that ref). [2]
Sources: [1], [2]
🏁 Script executed:
#!/bin/bash
# Look for documentation or usage of .main.commit files
echo "=== Search for .main.commit references ==="
rg -i "\.main\.commit|\.dev\.commit" --type-list | head
echo -e "\n=== Search in documentation ==="
find . -maxdepth 3 \( -name "README*" -o -name "*.md" \) -type f -exec grep -l "commit" {} \; 2>/dev/null | head -10
echo -e "\n=== Check .dev.commit for comparison ==="
cat -n .dev.commit
echo -e "\n=== Look for scripts that use these files ==="
rg "main\.commit|dev\.commit" --type bash --type python --type sh | head -20Repository: NVIDIA-NeMo/Megatron-Bridge
Length of output: 840
🌐 Web query:
NVIDIA-NeMo Megatron-Bridge .main.commit .dev.commit submodule pointer
💡 Result:
In NVIDIA-NeMo/Megatron-Bridge the Megatron-Core (Megatron-LM) submodule at 3rdparty/Megatron-LM is pinned via two “pointer” files:
.main.commit→980211ae6308dd541ec24bfe5af664ef31215256(the submodule commit the repo tracks by default) [1].dev.commit→c72c4599012297cfbd1d57e006b544478b6bbf78(an alternate “dev” pin used by the repo’s Megatron-Core switching workflow) [2]
These two pins are referenced by the repo’s Megatron-Core switching mechanism (documented in the README under “Megatron-Core Submodule (main & dev)”). [3]
Sources: [1] [2] [3]
This commit hash appears to be incorrect for updating the Megatron-Core submodule.
Verification reveals that d7288711ba278d160d2a5a22c099915c9fe1395c is from NVIDIA/Megatron-LM PR #4237 titled "cp: Bump nvrx"—a dependency update, not a Megatron-Core release commit. The .main.commit file is a submodule pointer that should pin the Megatron-Core version. Confirm whether this commit hash is the intended value or if it should be updated to a different commit that actually corresponds to the desired Megatron-Core release.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.main.commit at line 1, The .main.commit entry currently contains the commit
hash d7288711ba278d160d2a5a22c099915c9fe1395c which is from NVIDIA/Megatron-LM
PR `#4237` and not a Megatron-Core release; verify the intended Megatron-Core
revision and replace the value in .main.commit with the correct Megatron-Core
commit hash (or revert this change if the submodule update was accidental),
ensuring the new hash actually exists in the Megatron-Core repository and pins
the desired release/tag; update the commit message to reflect the correct
submodule target if you change the hash.
3 participants
🚀 PR to bump
uv.lockinr0.4.0.🤖 This PR will be merged automatically once CI passes.
Summary by CodeRabbit