Skip to content

ci: Use environment for twine/slack#2561

Merged
ko3n1g merged 1 commit intomainfrom
ko3n1g/ci/use-environment-again
Feb 26, 2026
Merged

ci: Use environment for twine/slack#2561
ko3n1g merged 1 commit intomainfrom
ko3n1g/ci/use-environment-again

Conversation

@ko3n1g
Copy link
Copy Markdown
Contributor

@ko3n1g ko3n1g commented Feb 26, 2026

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Summary by CodeRabbit

  • Chores
    • Updated internal release workflow configuration for improved secret handling.

No user-facing changes in this release.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g requested a review from a team as a code owner February 26, 2026 10:47
@ko3n1g ko3n1g merged commit dca8994 into main Feb 26, 2026
5 of 7 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/ci/use-environment-again branch February 26, 2026 10:47
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 26, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 163febc and c61a796.

📒 Files selected for processing (1)
  • .github/workflows/release.yaml

📝 Walkthrough

Walkthrough

Simplified GitHub Actions release workflow secrets handling by replacing conditional branch-based secret lookups with direct secret references for TWINE_PASSWORD and SLACK_WEBHOOK, reducing configuration complexity while maintaining the same control flow.

Changes

Cohort / File(s) Summary
Release Workflow Configuration
.github/workflows/release.yaml
Replaced conditional secret lookups with direct secret references: secrets.TWINE_PASSWORD (previously branch-conditional) and secrets.SLACK_RELEASE_ENDPOINT (previously branch-conditional).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • ci: Remove environments #2423: Also modifies TWINE_PASSWORD sourcing in .github/workflows/release.yaml with direct secret reference approach.
  • ci(fix): TestPyPI #2516: Simplifies conditional TWINE_PASSWORD resolution in GitHub Actions workflow by replacing branch-based selection with fixed secret references.

Suggested reviewers

  • thomasdhc
  • chtruong814
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ko3n1g/ci/use-environment-again

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

pengdurice pushed a commit to pengdurice/Megatron-Bridge that referenced this pull request Feb 26, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: pengdurice <pengduhit@gmail.com>
copy-pr-bot bot pushed a commit that referenced this pull request Mar 19, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant