Skip to content

ci(fix): TestPyPI#2516

Merged
ko3n1g merged 3 commits intomainfrom
ko3n1g/ci/test-pypi
Feb 25, 2026
Merged

ci(fix): TestPyPI#2516
ko3n1g merged 3 commits intomainfrom
ko3n1g/ci/test-pypi

Conversation

@ko3n1g
Copy link
Copy Markdown
Contributor

@ko3n1g ko3n1g commented Feb 24, 2026

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Summary by CodeRabbit

  • Chores
    • Updated build and publish workflow to consistently publish packages to the test PyPI repository instead of using conditional logic based on branch names.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g requested a review from a team as a code owner February 24, 2026 22:20
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f1263ad and 8c1b6cb.

📒 Files selected for processing (1)
  • .github/workflows/build-test-publish-wheel.yml

📝 Walkthrough

Walkthrough

The build-test-publish-wheel GitHub Actions workflow is simplified by replacing conditional logic with static values. The no-publish flag is now always set to false, and TWINE_PASSWORD consistently uses the SVC_PYPI_TEST_TOKEN secret instead of choosing between production and test tokens based on branch conditions.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/build-test-publish-wheel.yml
Simplified publishing logic: no-publish flag changed from conditional to static false, and TWINE_PASSWORD now always resolves to SVC_PYPI_TEST_TOKEN instead of conditionally selecting between production and test secrets.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • ci(fix): Wheel build #2192: Modifies the same build-test-publish-wheel workflow with related changes to publishing parameters (no-publish and TWINE_PASSWORD).

Suggested labels

r0.3.0

Suggested reviewers

  • thomasdhc
  • chtruong814
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ci(fix): TestPyPI' is specific and directly relates to the main change: fixing CI configuration to publish to TestPyPI instead of production PyPI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed PR contains only minor CI/CD workflow configuration changes (2 lines modified in .github/workflows/build-test-publish-wheel.yml) that do not constitute major changes, new features, or breaking changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ko3n1g/ci/test-pypi

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ko3n1g ko3n1g enabled auto-merge (squash) February 25, 2026 13:34
@coderabbitai coderabbitai bot mentioned this pull request Feb 26, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants