Conversation
Signed-off-by: oliver könig <okoenig@nvidia.com>
📝 WalkthroughWalkthroughMultiple GitHub Actions workflows are updated to remove explicit environment bindings (nemo-ci and main) across jobs. Additionally, PyPI authentication in publishing workflows switches from username-secret to token-based credentials, with conditional branch-aware token selection. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/cicd-approve-test-queue.yml (1)
84-135:⚠️ Potential issue | 🟠 Major
approve-queuebecomes a no-op — consider disabling or removing this workflow.The script's entire value depends on "CICD NeMo" workflow runs entering
waitingstate, which only occurs when a job has an activeenvironment:binding with a required-reviewer protection rule. Per this PR's broader changes, allenvironment:declarations are being removed fromcicd-main.yml. With no environment gates left,pending_workflows(line 99–100) will always be an empty list and the approval loop (lines 108–133) will never execute. The workflow will continue burning CI minutes (scheduled every 5 minutes) with zero effect.Consider either disabling the schedule trigger or deleting the workflow entirely as part of this cleanup.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/cicd-approve-test-queue.yml around lines 84 - 135, The approve-queue workflow is now a no-op because pending_workflows (the list filtered from make_request("actions/runs?status=waiting") for runs named "CICD NeMo") will always be empty after removing environment gates; remove wasted CI runs by either deleting this workflow file entirely or disabling its schedule trigger (remove the cron entry or stop the scheduled dispatch), and if you prefer a safer short-term change add an early guard that exits immediately when no waiting runs are found (check pending_workflows before the approval loop and exit 0) so MAX_CONCURRENCY and the approval loop never run unnecessarily.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.github/workflows/cicd-approve-test-queue.yml:
- Around line 84-135: The approve-queue workflow is now a no-op because
pending_workflows (the list filtered from
make_request("actions/runs?status=waiting") for runs named "CICD NeMo") will
always be empty after removing environment gates; remove wasted CI runs by
either deleting this workflow file entirely or disabling its schedule trigger
(remove the cron entry or stop the scheduled dispatch), and if you prefer a
safer short-term change add an early guard that exits immediately when no
waiting runs are found (check pending_workflows before the approval loop and
exit 0) so MAX_CONCURRENCY and the approval loop never run unnecessarily.
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
What does this PR do ?
This simplifies secrets management, and avoid polluting the PR history with deployment updates.
Changelog
GitHub Actions CI
See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information
Summary by CodeRabbit