fix errors in obs_input_reanl* found by comparing with obs_input_ops#13
Conversation
|
@CatherineThomas-NOAA: This PR contains more updates to @ClaraDraper-NOAA), you also have changes which we need to get into build_gsinfo-fix. I'm referring to g-w issue #. We need a build_gsinfo-fix PR to get these changes into this repo and then pull them into GFS v17 via GSI-fix, GSI, and g-w PRs. @CatherineThomas-NOAA and @jswhit: Do we also need PR #9 in GFS v17? Instead of opening separate GSI-fix, GSI, and g-w PRs for each build_gsinfo-fix PR, let's get all the GFS v17 changes we need committed to build_gsinfo-fix and then open a single set of GSI-fix, GSI, and g-w PRs to bring these changes into GFS v17. |
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
Looks good. One question about amsua_aqua.
| amsuabufr amsua n16 amsua_n16 0.0 1 1 | ||
| amsuabufr amsua n17 amsua_n17 0.0 1 1 | ||
| amsuabufr amsua n18 amsua_n18 0.0 1 1 | ||
| ! airsbufr amsua aqua amsua_aqua 0.0 1 1 |
There was a problem hiding this comment.
I think this line (line 72) should be uncommented for NCEP. It's my understanding that the NCEP airsbufr file contains AIRS and AMSU-A brightness temperatures. HSB data was also in the file when this sensor worked.
The comment on line 73 is not needed, is it? This is the NCEP obs_input file.
If we uncomment line 72, we don't need line 74.
What do you think @ilianagenkova and @ADCollard?
PR to correct the 2m gross errors is here. |
|
@RussTreadon-NOAA we have reprocessed airs and aqua amsua files in NNJA (the airs files do not contain any amsua data as they do in the NCEP dumps). There's no reason not to use these for reanalysis. The nasa and ncep obs_input_reanl files are just to switch between different versions of the ozone obs - the NASA netcdf versions and the operational NCEP bufr dumps. It's not clear which we will use for reanalysis, since we currently only have the NASA files for part of the record. |
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
Approve.
These changes are needed in main and gfsv17_historical.
|
@jswhit : I apologize for bothering you with PRs while you are on leave. Would it make sense to
This would allow EMC staff to merge PRs into the forked build_gsinfo-fix and then sequentially update GSI-fix, GSI, and g-w hashes for use in GFS v17 parallels. The downside is that NOAA-PSL and NOAA-EMC build_gsinfo-fix could diverge over time. What do you think? |
|
@RussTreadon-NOAA not sure if an EMC fork would be any easier than me adding you and others at EMC as contributors to this repo. |
Sure, that works. I prefer not having multiple repos. |
|
@RussTreadon-NOAA I added you as a collaborator with write access, in case I'm not around to merge emergency updates. You should have an invite in your inbox. |
|
Got it and accepted! Thank you @jswhit |
No description provided.