Skip to content

update fix to bring in update obs_input files#972

Closed
RussTreadon-NOAA wants to merge 1 commit into
NOAA-EMC:developfrom
RussTreadon-NOAA:bugfix/dsfcalc
Closed

update fix to bring in update obs_input files#972
RussTreadon-NOAA wants to merge 1 commit into
NOAA-EMC:developfrom
RussTreadon-NOAA:bugfix/dsfcalc

Conversation

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Dec 16, 2025

Description
This PR updates the fix hash to bring in changes to the obs_input.

Type of change

  • Bug fix - remove duplicates and set dsfcalc=1 for in obs_input files

How Has This Been Tested?

Tested in Cactus GFS v18 prgsi.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

@CatherineThomas-NOAA and @CoryMartin-NOAA : This PR contains updates to the obs_input file used in GFS v17 parallels. The updated obs_input file resolves the problem discussed in g-w issue #4340

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

WCOSS2 ctests

Install RussTreadon-NOAA:bugfix/dsfcalc at 128b3c7 as updat and develop at 4b49982 as contrl on Cactus. Run ctests with following results

Test project /lfs/h2/emc/da/noscrub/russ.treadon/git/gsi/dsfcalc/build
    Start 1: global_4denvar
    Start 2: rtma
    Start 3: rrfs_3denvar_rdasens
    Start 4: hafs_4denvar_glbens
    Start 5: hafs_3denvar_hybens
    Start 6: global_enkf
1/6 Test #3: rrfs_3denvar_rdasens .............   Passed  731.05 sec
2/6 Test #6: global_enkf ......................   Passed  857.24 sec
3/6 Test #2: rtma .............................   Passed  1095.29 sec
4/6 Test #5: hafs_3denvar_hybens ..............   Passed  1222.31 sec
5/6 Test #4: hafs_4denvar_glbens ..............   Passed  1342.14 sec
6/6 Test #1: global_4denvar ...................   Passed  1924.33 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) = 1924.47 sec

This is an expected result. This PR changes the fix submodule hash. The only changes in the updated fix hash are obs_input files in fix/build_gsinfo. None of the ctests use any files from fix/build_gsinfo.

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

@CatherineThomas-NOAA , @ClaraDraper-NOAA , @CoryMartin-NOAA , @JessicaMeixner-NOAA , @RuiyuSun

Based on these and subsequent comments in build_gsinfo-fix PR #13, we probably should hold off on merging this PR into GSI develop.

It looks like we have a few more GFS v17 changes to get into build_gsinfo-fix. Once these changes are committed to build_gsinfo-fix, we open a GSI-fix PR to pull in the updated build-gsinfo-fix. After this we update the fix/ submodule hash in this PR. Then we open a g-w PR to update the gsi_enkf.fd hash. We have a lengthy string of PRs depending on other PRs to work through.

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

Close as duplicate. Changes entered develop via PR #973

@RussTreadon-NOAA RussTreadon-NOAA deleted the bugfix/dsfcalc branch December 18, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant