Add hydrometeor uncertainty#558
Conversation
| i_T_Q_adjust=${i_T_Q_adjust}, | ||
| l_rtma3d=${l_rtma3d}, | ||
| i_precip_vertical_check=${i_precip_vertical_check}, | ||
| i_uncertainty=${i_uncertainty}, |
There was a problem hiding this comment.
If it only takes the value of "True" or "False", suggest using "l_uncerntainty"
There was a problem hiding this comment.
Thanks, I switched the type of the variable but forgot to change the name to match. I'll make that change.
| if [ ${i_uncertainty} == ".true." ]; then | ||
| # Copy analysis fields into uncertainties - data will be overwritten | ||
| echo "EXREGIONAL_NONVARCLDANL.SH: copy tracer file into uncertainty file " | ||
| cp_vrfy ${bkpath}/fv_tracer.res.tile1.nc ${bkpath}/fv_tracer.unc.tile1.nc |
There was a problem hiding this comment.
This uncertainty only applies to cloud analysis results?
There was a problem hiding this comment.
Yes, EMC is working on uncertainties for some other basic fields, and we we work on extending the uncertainty to other aviation fields like cloud tops, ceilings, etc.
|
Thanks for the review so far, I made the changes suggested by Guoqing and retested to make sure I hadn't missed anything. |
| i_T_Q_adjust=1 | ||
| l_rtma3d=.false. | ||
| i_precip_vertical_check=0 | ||
| l_uncertainty=.false. |
There was a problem hiding this comment.
Thanks for the changes! Since this only applies to hydrometeors, I would think it may be better to let the variable name reflect this. How about "l_cloud_uncertainty", or "l_cld_uncertainty"?
There was a problem hiding this comment.
good idea! I'll make that change this evening or tomorrow morning.
| if [ "${IO_LAYOUT_Y}" == "1" ]; then | ||
| ln_vrfy -s ${bkpath}/fv_core.res.tile1.nc fv3_dynvars | ||
| ln_vrfy -s ${bkpath}/fv_tracer.res.tile1.nc fv3_tracer | ||
| ln_vrfy -s ${bkpath}/fv_tracer.unc.tile1.nc fv3_tracer_unc |
There was a problem hiding this comment.
This will crash when "l_cld_uncertainty" is false
| iii=$(printf %4.4i $ii) | ||
| ln_vrfy -s ${bkpath}/fv_core.res.tile1.nc.${iii} fv3_dynvars.${iii} | ||
| ln_vrfy -s ${bkpath}/fv_tracer.res.tile1.nc.${iii} fv3_tracer.${iii} | ||
| ln_vrfy -s ${bkpath}/fv_tracer.unc.tile1.nc.${iii} fv3_tracer_unc.${iii} |
There was a problem hiding this comment.
This will crash when "l_cld_uncertainty" is false
3 participants
NOTE: This PR was superseded by an updated version, #580 Closing this branch/PR.
DESCRIPTION OF CHANGES:
There is a effort between EMC and GSL to include more information about uncertainty for RTMA aviation-related fields. This is an initial set to include hydrometeor uncertainty in the RTMA output.
Specifically, the following changes were made:
Default is .false. (off), so if the flag is not included it or set to off, the uncertainty file creation is not performed.
Note that this is part I of a two-part update. The changes to overwrite the fields in the template netcdf file are in the rrfs_utils/cloudanalysis fortran code, which will be included in a separate PR (rrfs_utl #41). This PR should be merge before or with the rrfs_utl #41 PR.
Type of change
TESTS CONDUCTED:
DEPENDENCIES:
This is part I of a two-part update. The changes to overwrite the fields in the template netcdf file are in the rrfs_utils/cloudanalysis fortran code, which will be included in a separate PR (rrfs_utl #41). This PR should be merge before or with the rrfs_utl #41 PR.
DOCUMENTATION:
None
ISSUE:
None.
CHECKLIST