Skip to content

initial script changes for hydrometeor uncertainty with RTMA parallel…#580

Merged
cshartsough merged 2 commits into
feature/RRFS_dev1from
add_hydrometeor_uncertainty_parallel
Oct 25, 2023
Merged

initial script changes for hydrometeor uncertainty with RTMA parallel…#580
cshartsough merged 2 commits into
feature/RRFS_dev1from
add_hydrometeor_uncertainty_parallel

Conversation

@cshartsough
Copy link
Copy Markdown

@cshartsough cshartsough commented Oct 19, 2023

NOTE: This PR replaces a previous PR in regional_workflow, #558

DESCRIPTION OF CHANGES:

There is a effort between EMC and GSL to include more information about uncertainty for RTMA aviation-related fields. This is an initial set to include hydrometeor uncertainty in the RTMA output.

Specifically, the following changes were made:

  • Add a logical flag (i_uncertainty) to the config_defaults script to turn on/off the creation of the uncertainties file. Default is .false. (off), so if the flag is not included it or set to off, the uncertainty file creation is not performed.
  • Create a template in the exregional_nonvarcldanl script for the uncertainty netcdf file by copying the fcst_fv3lam/INPUT/tracer file into the same directory.

Note that this is part I of a two-part update. The changes to overwrite the fields in the template netcdf file are in the rrfs_utils/cloudanalysis fortran code, which will be included in a separate PR (rrfs_utl #49). This PR should be merge with the rrfs_utl #49 PR.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • [ ]

TESTS CONDUCTED:

  • hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • [ x] jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

This is part I of a two-part update. The changes to overwrite the fields in the template netcdf file are in the rrfs_utils/cloudanalysis fortran code, which will be included in a separate PR (rrfs_utl #41). This PR should be merge before or with the rrfs_utl #41 PR.

DOCUMENTATION:

None

ISSUE:

None.

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • [x ] I have performed a self-review of my own code using the Code Reviewer's Guide
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Comment thread scripts/exregional_nonvarcldanl.sh Outdated
if [ "${IO_LAYOUT_Y}" == "1" ]; then
ln_vrfy -s ${bkpath}/fv_core.res.tile1.nc fv3_dynvars
ln_vrfy -s ${bkpath}/fv_tracer.res.tile1.nc fv3_tracer
ln_vrfy -s ${bkpath}/fv_tracer.unc.tile1.nc fv3_tracer_unc
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will crash when "l_cld_uncertainty" is false

Comment thread scripts/exregional_nonvarcldanl.sh Outdated
iii=$(printf %4.4i $ii)
ln_vrfy -s ${bkpath}/fv_core.res.tile1.nc.${iii} fv3_dynvars.${iii}
ln_vrfy -s ${bkpath}/fv_tracer.res.tile1.nc.${iii} fv3_tracer.${iii}
ln_vrfy -s ${bkpath}/fv_tracer.unc.tile1.nc.${iii} fv3_tracer_unc.${iii}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will crash when "l_cld_uncertainty" is false

@cshartsough
Copy link
Copy Markdown
Author

Thanks for catching the places that needed conditionals added. I've updated the code to only set up the links if l_cld_uncertainty is set to .true.

@hu5970
Copy link
Copy Markdown

hu5970 commented Oct 25, 2023

@cshartsough Please merge this one and delete PR 558

@cshartsough cshartsough merged commit 5040544 into feature/RRFS_dev1 Oct 25, 2023
@cshartsough cshartsough mentioned this pull request Oct 25, 2023
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants