initial script changes for hydrometeor uncertainty with RTMA parallel…#580
Merged
cshartsough merged 2 commits intoOct 25, 2023
Merged
Conversation
hu5970
reviewed
Oct 23, 2023
| if [ "${IO_LAYOUT_Y}" == "1" ]; then | ||
| ln_vrfy -s ${bkpath}/fv_core.res.tile1.nc fv3_dynvars | ||
| ln_vrfy -s ${bkpath}/fv_tracer.res.tile1.nc fv3_tracer | ||
| ln_vrfy -s ${bkpath}/fv_tracer.unc.tile1.nc fv3_tracer_unc |
There was a problem hiding this comment.
This will crash when "l_cld_uncertainty" is false
| iii=$(printf %4.4i $ii) | ||
| ln_vrfy -s ${bkpath}/fv_core.res.tile1.nc.${iii} fv3_dynvars.${iii} | ||
| ln_vrfy -s ${bkpath}/fv_tracer.res.tile1.nc.${iii} fv3_tracer.${iii} | ||
| ln_vrfy -s ${bkpath}/fv_tracer.unc.tile1.nc.${iii} fv3_tracer_unc.${iii} |
There was a problem hiding this comment.
This will crash when "l_cld_uncertainty" is false
Author
|
Thanks for catching the places that needed conditionals added. I've updated the code to only set up the links if |
hu5970
approved these changes
Oct 25, 2023
|
@cshartsough Please merge this one and delete PR 558 |
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This PR replaces a previous PR in regional_workflow, #558
DESCRIPTION OF CHANGES:
There is a effort between EMC and GSL to include more information about uncertainty for RTMA aviation-related fields. This is an initial set to include hydrometeor uncertainty in the RTMA output.
Specifically, the following changes were made:
Note that this is part I of a two-part update. The changes to overwrite the fields in the template netcdf file are in the rrfs_utils/cloudanalysis fortran code, which will be included in a separate PR (rrfs_utl #49). This PR should be merge with the rrfs_utl #49 PR.
Type of change
TESTS CONDUCTED:
DEPENDENCIES:
This is part I of a two-part update. The changes to overwrite the fields in the template netcdf file are in the rrfs_utils/cloudanalysis fortran code, which will be included in a separate PR (rrfs_utl #41). This PR should be merge before or with the rrfs_utl #41 PR.
DOCUMENTATION:
None
ISSUE:
None.
CHECKLIST