Skip to content

Add hydrometeor uncertainty #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cshartsough wants to merge 5 commits into from
Closed

Add hydrometeor uncertainty #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
013c6da
initial uncertainty code
cshartsough Aug 16, 2023
2dab9e8
change flag to logical, clean commented-out lines
cshartsough Aug 22, 2023
1b2a89e
change uncertainty flag, now a logical, to l_uncertainty
cshartsough Aug 23, 2023
5383328
change to l_uncertainty in config_defaults
cshartsough Aug 23, 2023
1bdf045
change flag name to be more specific, l_cld_uncertainty
cshartsough Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions scripts/exregional_nonvarcldanl.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,12 @@ else
bkpath=${cycle_dir}${slash_ensmem_subdir}/fcst_fv3lam${cycle_tag}/INPUT
fi

if [ ${l_cld_uncertainty} == ".true." ]; then
# Copy analysis fields into uncertainties - data will be overwritten
echo "EXREGIONAL_NONVARCLDANL.SH: copy tracer file into uncertainty file "
cp_vrfy ${bkpath}/fv_tracer.res.tile1.nc ${bkpath}/fv_tracer.unc.tile1.nc
Copy link
Copy Markdown
Collaborator

@guoqing-noaa guoqing-noaa Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This uncertainty only applies to cloud analysis results?

Copy link
Copy Markdown
Author

@cshartsough cshartsough Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, EMC is working on uncertainties for some other basic fields, and we we work on extending the uncertainty to other aviation fields like cloud tops, ceilings, etc.

fi

n_iolayouty=$(($IO_LAYOUT_Y-1))
list_iolayout=$(seq 0 $n_iolayouty)

Expand All @@ -175,6 +181,7 @@ if [ -r "${bkpath}/coupler.res" ]; then # Use background from warm restart
if [ "${IO_LAYOUT_Y}" == "1" ]; then
ln_vrfy -s ${bkpath}/fv_core.res.tile1.nc fv3_dynvars
ln_vrfy -s ${bkpath}/fv_tracer.res.tile1.nc fv3_tracer
ln_vrfy -s ${bkpath}/fv_tracer.unc.tile1.nc fv3_tracer_unc
Copy link
Copy Markdown

@hu5970 hu5970 Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will crash when "l_cld_uncertainty" is false

ln_vrfy -s ${bkpath}/sfc_data.nc fv3_sfcdata
ln_vrfy -s ${bkpath}/phy_data.nc fv3_phydata
else
Expand All @@ -183,6 +190,7 @@ if [ -r "${bkpath}/coupler.res" ]; then # Use background from warm restart
iii=$(printf %4.4i $ii)
ln_vrfy -s ${bkpath}/fv_core.res.tile1.nc.${iii} fv3_dynvars.${iii}
ln_vrfy -s ${bkpath}/fv_tracer.res.tile1.nc.${iii} fv3_tracer.${iii}
ln_vrfy -s ${bkpath}/fv_tracer.unc.tile1.nc.${iii} fv3_tracer_unc.${iii}
Copy link
Copy Markdown

@hu5970 hu5970 Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will crash when "l_cld_uncertainty" is false

ln_vrfy -s ${bkpath}/sfc_data.nc.${iii} fv3_sfcdata.${iii}
ln_vrfy -s ${bkpath}/phy_data.nc.${iii} fv3_phydata.${iii}
ln_vrfy -s ${gridspec_dir}/fv3_grid_spec.${iii} fv3_grid_spec.${iii}
Expand Down Expand Up @@ -312,6 +320,7 @@ cat << EOF > gsiparm.anl
i_T_Q_adjust=${i_T_Q_adjust},
l_rtma3d=${l_rtma3d},
i_precip_vertical_check=${i_precip_vertical_check},
l_cld_uncertainty=${l_cld_uncertainty},
/
EOF

Expand Down
1 change: 1 addition & 0 deletions ush/config_defaults.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,6 +715,7 @@ i_use_2mT4B=0
i_T_Q_adjust=1
l_rtma3d=.false.
i_precip_vertical_check=0
l_cld_uncertainty=.false.
# &CHEM
laeroana_fv3smoke=.false.
berror_fv3_cmaq_regional=.false.
Expand Down