Skip to content

Fix RAP (Grell Freitas) decomp b4b issues#141

Merged
SamuelTrahanNOAA merged 16 commits into
NOAA-GSL:gsl/developfrom
SamuelTrahanNOAA:bugfix/gf-dom-fix-to-gsl
Jun 14, 2022
Merged

Fix RAP (Grell Freitas) decomp b4b issues#141
SamuelTrahanNOAA merged 16 commits into
NOAA-GSL:gsl/developfrom
SamuelTrahanNOAA:bugfix/gf-dom-fix-to-gsl

Conversation

@SamuelTrahanNOAA
Copy link
Copy Markdown
Collaborator

@SamuelTrahanNOAA SamuelTrahanNOAA commented Jun 14, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

Description

Fixes a bug in the GF scheme that prevented bit-for-bit reproducibility. This is the same as:

ufs-community#1257

Issue(s) addressed

ufs-community#953

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

NOAA-GSL/ccpp-physics#156
NOAA-GSL/fv3atm#148

@SamuelTrahanNOAA SamuelTrahanNOAA changed the title Bugfix/gf dom fix to gsl Fix RAP (Grell Freitas) decomp b4b issues Jun 14, 2022
@SamuelTrahanNOAA SamuelTrahanNOAA merged commit 576b58e into NOAA-GSL:gsl/develop Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants