Skip to content

Native NDSL types for GT4Py 2D temporaries#280

Merged
FlorianDeconinck merged 5 commits into
NOAA-GFDL:developfrom
FlorianDeconinck:feature/ndsl_types_for_2D_temporaries
Oct 27, 2025
Merged

Native NDSL types for GT4Py 2D temporaries#280
FlorianDeconinck merged 5 commits into
NOAA-GFDL:developfrom
FlorianDeconinck:feature/ndsl_types_for_2D_temporaries

Conversation

@FlorianDeconinck
Copy link
Copy Markdown
Collaborator

Description

Following the merge of GridTools/gt4py#2314 which brought 2D temporaries to GT4Py, we adjust the FrozenStencil to pass down NDSL gtscript types overload for a seamless experience.

Upgrades GT4Py to include:

  • 2D temporaries
  • Removal of cuda backend

How has this been tested?

Unit test covers new usage of 2D temporaries.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. add new modules to docs/docstrings/)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@FlorianDeconinck FlorianDeconinck requested review from romanc and twicki and removed request for romanc October 24, 2025 15:11
Copy link
Copy Markdown
Collaborator

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not make tests more complicated than the need to be. Otherwise LGTM!

Comment thread tests/dsl/test_stencil.py Outdated
twicki
twicki previously requested changes Oct 24, 2025
Copy link
Copy Markdown
Collaborator

@twicki twicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test still depdends on the cuda backend, here a quick fix: FlorianDeconinck#1

@FlorianDeconinck
Copy link
Copy Markdown
Collaborator Author

Block behind GridTools/gt4py#2343

@FlorianDeconinck FlorianDeconinck added Scheduled for next Release To be merged before the next release Enhancement New feature or request labels Oct 24, 2025
@FlorianDeconinck FlorianDeconinck removed the request for review from twicki October 27, 2025 12:53
@FlorianDeconinck FlorianDeconinck dismissed twicki’s stale review October 27, 2025 13:04

It's been fixed and the reviewer is presently hugging a baby, a fine activity.

@FlorianDeconinck FlorianDeconinck added this pull request to the merge queue Oct 27, 2025
Merged via the queue into NOAA-GFDL:develop with commit 53810ea Oct 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request Scheduled for next Release To be merged before the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants