cartesian[fix]: Remove hard check on ADR existing for experimental feature#2343
Merged
FlorianDeconinck merged 3 commits intoOct 24, 2025
Merged
Conversation
…g on installation mode.
7 tasks
romanc
approved these changes
Oct 24, 2025
Contributor
romanc
left a comment
There was a problem hiding this comment.
You will also need to remove the test that checks the ValueError. Otherwise, this looks good.
And yes since docs arent deployed we cant (and arguably in user code we shouldnt) check for ADR existence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of our "experimental" methodology is to write ADRs for each. To reinforce this, we check in the experimental feature warning that the ADR exists.
Alas' this doesn't really work on deployment:
docsnot deployed on installWe remove the check - we still reference the ADR on the
github