Skip to content

cartesian[fix]: Remove hard check on ADR existing for experimental feature#2343

Merged
FlorianDeconinck merged 3 commits into
GridTools:mainfrom
FlorianDeconinck:cartesian/fix/ADR_check
Oct 24, 2025
Merged

cartesian[fix]: Remove hard check on ADR existing for experimental feature#2343
FlorianDeconinck merged 3 commits into
GridTools:mainfrom
FlorianDeconinck:cartesian/fix/ADR_check

Conversation

@FlorianDeconinck
Copy link
Copy Markdown
Contributor

Description

Part of our "experimental" methodology is to write ADRs for each. To reinforce this, we check in the experimental feature warning that the ADR exists.

Alas' this doesn't really work on deployment:

  • docs not deployed on install
  • the way the path behaves are different depending on deployed or editable or local code

We remove the check - we still reference the ADR on the github

Copy link
Copy Markdown
Contributor

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will also need to remove the test that checks the ValueError. Otherwise, this looks good.

And yes since docs arent deployed we cant (and arguably in user code we shouldnt) check for ADR existence.

@FlorianDeconinck FlorianDeconinck merged commit 6afc229 into GridTools:main Oct 24, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants