Skip to content

[feature] Add 2D temporary support for NDSL's BoolFieldIJ#288

Merged
FlorianDeconinck merged 2 commits into
NOAA-GFDL:developfrom
FlorianDeconinck:feature/native_bool_2d_temp
Oct 28, 2025
Merged

[feature] Add 2D temporary support for NDSL's BoolFieldIJ#288
FlorianDeconinck merged 2 commits into
NOAA-GFDL:developfrom
FlorianDeconinck:feature/native_bool_2d_temp

Conversation

@FlorianDeconinck
Copy link
Copy Markdown
Collaborator

Description

Forgot booleans in #280. Booleans good. Have some booleans.

How has this been tested?

Update to unit test.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. add new modules to docs/docstrings/)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

Copy link
Copy Markdown
Collaborator

@twicki twicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How simple this system is if +5 can eneable a full type 🤩

Copy link
Copy Markdown
Collaborator

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@FlorianDeconinck FlorianDeconinck added this pull request to the merge queue Oct 28, 2025
Merged via the queue into NOAA-GFDL:develop with commit d69aa99 Oct 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants