ci: Re-enable flake8's F401 rule: no unused imports#180
Merged
Conversation
Update `__init__.py` files to use populate the `__all__` variable. That way, we don't need to handle `__init__.py` files separately.
8 tasks
jjuyeonkim
pushed a commit
to jjuyeonkim/NDSL
that referenced
this pull request
Sep 8, 2025
Update `__init__.py` files to use populate the `__all__` variable. That way, we don't need to handle `__init__.py` files separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up PR from #159, which accidentally added an exception for
F401(no unused imports) for all files. It turns out, we can re-enable this rule for all files if we populate the__all__variable in__init__.pyfiles, simplifying configuration.I've also commented on why we have the other exceptions and grouped them by "redundant with
black" and "clashing with NDSL/stencil syntax".How Has This Been Tested?
Running
pre-commitlocally.Checklist: