ci: Re-enable flake8's F401 rule: no unused imports

.pre-commit-config.yaml

@@ -42,14 +42,6 @@ repos:
         name: flake8
         language_version: python3
         additional_dependencies: [Flake8-pyproject]
-        exclude: |
-          (?x)^(
-          .*/__init__.py |
-          )$
-      - id: flake8
-        additional_dependencies: [Flake8-pyproject]
-        name: flake8 __init__.py files
-        files: "__init__.py"
 
   - repo: https://github.com/macisamuele/language-formatters-pre-commit-hooks
     rev: v2.15.0

ndsl/__init__.py

@@ -33,3 +33,58 @@
 from .testing.dummy_comm import DummyComm
 from .types import Allocator
 from .utils import MetaEnumStr
+
+
+__all__ = [
+    "dsl",
+    "CubedSphereCommunicator",
+    "TileCommunicator",
+    "LocalComm",
+    "MPIComm",
+    "NullComm",
+    "CubedSpherePartitioner",
+    "TilePartitioner",
+    "ConstantVersions",
+    "FV3CodePath",
+    "DaceConfig",
+    "DaCeOrchestration",
+    "FrozenCompiledSDFG",
+    "orchestrate",
+    "orchestrate_function",
+    "ArrayReport",
+    "DaCeProgress",
+    "MaxBandwidthBenchmarkProgram",
+    "StorageReport",
+    "WrappedHaloUpdater",
+    "FrozenStencil",
+    "GridIndexing",
+    "StencilFactory",
+    "TimingCollector",
+    "CompilationConfig",
+    "RunMode",
+    "StencilConfig",
+    "OutOfBoundsError",
+    "HaloExchangeSpec",
+    "HaloUpdater",
+    "HaloUpdateRequest",
+    "VectorInterfaceHaloUpdater",
+    "QuantityFactory",
+    "GridSizer",
+    "SubtileGridSizer",
+    "ndsl_log",
+    "NetCDFMonitor",
+    "Namelist",
+    "NullPerformanceCollector",
+    "PerformanceCollector",
+    "NullProfiler",
+    "Profiler",
+    "Experiment",
+    "Report",
+    "TimeReport",
+    "Quantity",
+    "FieldBundle",
+    "FieldBundleType",
+    "DummyComm",
+    "Allocator",
+    "MetaEnumStr",
+]

ndsl/checkpointer/__init__.py

@@ -7,3 +7,14 @@
     ThresholdCalibrationCheckpointer,
 )
 from .validation import ValidationCheckpointer
+
+
+__all__ = [
+    "NullCheckpointer",
+    "SnapshotCheckpointer",
+    "InsufficientTrialsError",
+    "SavepointThresholds",
+    "Threshold",
+    "ThresholdCalibrationCheckpointer",
+    "ValidationCheckpointer",
+]

ndsl/comm/__init__.py

@@ -6,3 +6,14 @@
     CachingRequestWriter,
 )
 from .comm_abc import Comm, Request
+
+
+__all__ = [
+    "CachingCommData",
+    "CachingCommReader",
+    "CachingCommWriter",
+    "CachingRequestReader",
+    "CachingRequestWriter",
+    "Comm",
+    "Request",
+]

ndsl/dsl/gt4py/__init__.py

@@ -51,3 +51,57 @@
     trunc,
     types,
 )
+
+
+__all__ = [
+    "BACKWARD",
+    "FORWARD",
+    "IJ",
+    "IJK",
+    "IK",
+    "JK",
+    "PARALLEL",
+    "Field",
+    "GlobalTable",
+    "I",
+    "J",
+    "K",
+    "Sequence",
+    "abs",
+    "acos",
+    "acosh",
+    "asin",
+    "asinh",
+    "atan",
+    "atanh",
+    "cbrt",
+    "ceil",
+    "compile_assert",
+    "computation",
+    "cos",
+    "cosh",
+    "exp",
+    "externals",
+    "floor",
+    "function",
+    "gamma",
+    "horizontal",
+    "interval",
+    "isfinite",
+    "isinf",
+    "isnan",
+    "log",
+    "log10",
+    "max",
+    "min",
+    "mod",
+    "region",
+    "sin",
+    "sinh",
+    "sqrt",
+    "stencil",
+    "tan",
+    "tanh",
+    "trunc",
+    "types",
+]

ndsl/grid/__init__.py

@@ -9,3 +9,17 @@
     HorizontalGridData,
     VerticalGridData,
 )
+
+
+__all__ = [
+    "HybridPressureCoefficients",
+    "GridDefinitions",
+    "MetricTerms",
+    "AngleGridData",
+    "ContravariantGridData",
+    "DampingCoefficients",
+    "DriverGridData",
+    "GridData",
+    "HorizontalGridData",
+    "VerticalGridData",
+]

ndsl/halo/__init__.py

@@ -3,3 +3,10 @@
     HaloDataTransformerCPU,
     HaloDataTransformerGPU,
 )
+
+
+__all__ = [
+    "HaloDataTransformer",
+    "HaloDataTransformerCPU",
+    "HaloDataTransformerGPU",
+]

ndsl/initialization/__init__.py

@@ -1 +1,6 @@
 from .sizer import GridSizer
+
+
+__all__ = [
+    "GridSizer",
+]

ndsl/monitor/__init__.py

@@ -1,2 +1,8 @@
 from .protocol import Monitor
 from .zarr_monitor import ZarrMonitor
+
+
+__all__ = [
+    "Monitor",
+    "ZarrMonitor",
+]

ndsl/performance/__init__.py

@@ -1,2 +1,5 @@
 from .config import PerformanceConfig
 from .timer import NullTimer, Timer
+
+
+__all__ = ["PerformanceConfig", "NullTimer", "Timer"]

ndsl/stencils/__init__.py

@@ -1 +1,8 @@
 from .corners import CopyCorners, CopyCornersXY, FillCornersBGrid
+
+
+__all__ = [
+    "CopyCorners",
+    "CopyCornersXY",
+    "FillCornersBGrid",
+]

ndsl/stencils/testing/__init__.py

@@ -14,3 +14,22 @@
     pad_field_in_j,
     read_serialized_data,
 )
+
+
+__all__ = [
+    "Grid",
+    "ParallelTranslate",
+    "ParallelTranslate2Py",
+    "ParallelTranslate2PyState",
+    "ParallelTranslateBaseSlicing",
+    "ParallelTranslateGrid",
+    "SavepointCase",
+    "Translate",
+    "assert_same_temporaries",
+    "TranslateFortranData2Py",
+    "TranslateGrid",
+    "pad_field_in_j",
+    "read_serialized_data",
+    "dataset_to_dict",
+    "copy_temporaries",
+]

pyproject.toml

@@ -44,7 +44,17 @@ source_pkgs = ["ndsl"]
 
 [tool.flake8]
 exclude = ["docs"]
-extend-ignore = ["E203", "E302", "E704", "F841", "W293", "E501", "W503", "F401"]
+extend-ignore = [
+  # Redundant with black formatter
+  "E302",  # Blank lines before function
+  "E501",  # Line too long
+  "E704",  # One statement per line
+  "W293",  # Blank line contains whitespace
+  "W503",  # Linebreak before binary operator
+  # Clashes with NDSL/stencil syntax
+  "E203",  # Space before ":", e.g. `field[1, :]`
+  "F841"  # Local variable assigned but unused
+]
 max-line-length = 88
 
 [tool.isort]