Fix: Adding Pace and PySHiELD unit tests back in to workflow

[fmalatino]

Description
This PR reintroduces the Pace and PySHiELD unit tests to the workflow. It also removes setup.cfg in favor of specifying its contents within pyproject.toml

Fixes # (issue)
If this is a hotfix to a released version, please specify it

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules
• New check tests, if applicable, are included
• Targeted model if this changed was triggered by a model need/shortcoming

[romanc]

Good to see the test harness working again.

I think adding an exception for "F401" (no unused imports) in the flake8 config shouldn't be and we should find a way to only allow unused imports in __init__.py files (as previously). If that takes longer than expected, feel free to break out re-enabling the pace / pyshield tests (which are independent of the pyproject.toml changes.

[romanc]

This adds the exception for F401 (no unused imports) to all files (not just __init__.py files as before). I think it would be good if we pruned unused imports in all files other than __init__.py (which can have convenience imports/exports).

[FlorianDeconinck]

In the __init__.py you can do

import .moduleA
import .moduleB

__all__ = ["moduleA", "moduleB"]

[romanc]

Yes, this is why the F401 exception should be there for __init__.py files. I'm arguing it should only be there for __init__.py files (and not for any other python files).

[FlorianDeconinck]

But if you do the __all__, which is the spec, I don't think you need the F401 at all (I could be wrong)

[romanc]

Ah okay, today I learned ... Good to know!

[romanc]

Thanks!

[oelbert]

👍

[romanc]

Some small things we learned from the NDSL repo recently.

[romanc]

If everybody agrees that we should merge now, we can also do the above in a follow-up.

[romanc]

Seems like I need to formally approve to make a follow-up possible, so here we go.

[fmalatino]

Seems like I need to formally approve to make a follow-up possible, so here we go.

I will make these changes in this PR as I think they are also relevant to this one and dismiss stale reviews

[romanc]

Nice! 🚀

[romanc]

Ship it! 🚢