Skip to content

Remove deprecated floating_point_precision()#140

Merged
FlorianDeconinck merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/remove-deprecated-float-precision-function
May 14, 2025
Merged

Remove deprecated floating_point_precision()#140
FlorianDeconinck merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/remove-deprecated-float-precision-function

Conversation

@romanc
Copy link
Copy Markdown
Collaborator

@romanc romanc commented May 9, 2025

Description

Remove deprecated function as discussed in NOAA-GFDL/pyFV3#54 (comment). The function was replaced with get_precision() in 2025.03.00.

How Has This Been Tested?

Fixed (upstream) PyFV3 in NOAA-GFDL/pyFV3#54. Found no occurrences in pace and PySHiELD. Updated NDSL & PyFV3 versions of pace.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A

@romanc romanc requested a review from FlorianDeconinck May 9, 2025 13:56
@romanc romanc force-pushed the romanc/remove-deprecated-float-precision-function branch from 825ce7c to 4fe7fbf Compare May 9, 2025 13:58
@romanc

This comment was marked as outdated.

@romanc

This comment was marked as outdated.

@romanc romanc force-pushed the romanc/remove-deprecated-float-precision-function branch 2 times, most recently from 7c6833f to 68dd63c Compare May 13, 2025 19:19
@romanc

This comment was marked as outdated.

@romanc

This comment was marked as outdated.

The function was replaced with `get_precision()` in 2025.03.00.
@romanc romanc force-pushed the romanc/remove-deprecated-float-precision-function branch from 68dd63c to 4bfacfe Compare May 14, 2025 06:39
@romanc
Copy link
Copy Markdown
Collaborator Author

romanc commented May 14, 2025

Alright - this is finally up for show after updating NDSL and PyFV3 in pace.

Copy link
Copy Markdown
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers for the dependency un-noodling

@FlorianDeconinck FlorianDeconinck merged commit c38e64f into NOAA-GFDL:develop May 14, 2025
5 checks passed
@romanc romanc deleted the romanc/remove-deprecated-float-precision-function branch May 15, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants