Remove deprecated floating_point_precision()#140
Merged
FlorianDeconinck merged 1 commit intoMay 14, 2025
Merged
Conversation
825ce7c to
4fe7fbf
Compare
This comment was marked as outdated.
This comment was marked as outdated.
7 tasks
This comment was marked as outdated.
This comment was marked as outdated.
7c6833f to
68dd63c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
The function was replaced with `get_precision()` in 2025.03.00.
68dd63c to
4bfacfe
Compare
4 tasks
Collaborator
Author
|
Alright - this is finally up for show after updating NDSL and PyFV3 in pace. |
FlorianDeconinck
approved these changes
May 14, 2025
Collaborator
FlorianDeconinck
left a comment
There was a problem hiding this comment.
Cheers for the dependency un-noodling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove deprecated function as discussed in NOAA-GFDL/pyFV3#54 (comment). The function was replaced with
get_precision()in 2025.03.00.How Has This Been Tested?
Fixed (upstream) PyFV3 in NOAA-GFDL/pyFV3#54. Found no occurrences in pace and PySHiELD. Updated NDSL & PyFV3 versions of pace.
Checklist: