Skip to content

Avoid deprecated floating_point_precision()#54

Merged
FlorianDeconinck merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/get_precision
May 9, 2025
Merged

Avoid deprecated floating_point_precision()#54
FlorianDeconinck merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/get_precision

Conversation

@romanc
Copy link
Copy Markdown
Collaborator

@romanc romanc commented May 9, 2025

Description

With PR NOAA-GFDL/NDSL#104 that function was deprecated in favor of get_precision(). The new function is a drop-in replacement for the old one. Since we use NDSL version 2025.03.00 now, we can use the new function name.

How Has This Been Tested?

Should be covered by CI.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included: N/A
  • Targeted model if this changed was triggered by a model need/shortcoming: N/A

With PR NOAA-GFDL/NDSL#104 that function was
deprecated in favor of `get_precision()`. The new fuction is a drop-in
replacement for the old one.
@romanc
Copy link
Copy Markdown
Collaborator Author

romanc commented May 9, 2025

/cc @FlorianDeconinck

We should probably add a deprecation warning in NDSL, such that we can then remove the function in a future version (after a grace period).

@FlorianDeconinck
Copy link
Copy Markdown
Collaborator

We should even be more aggresive, drop the old one altogether and fix the failures.

@FlorianDeconinck FlorianDeconinck merged commit 1b2057f into NOAA-GFDL:develop May 9, 2025
4 checks passed
@romanc romanc deleted the romanc/get_precision branch May 9, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants