Avoid deprecated floating_point_precision()#54
Merged
Conversation
With PR NOAA-GFDL/NDSL#104 that function was deprecated in favor of `get_precision()`. The new fuction is a drop-in replacement for the old one.
Collaborator
Author
|
We should probably add a deprecation warning in NDSL, such that we can then remove the function in a future version (after a grace period). |
Collaborator
|
We should even be more aggresive, drop the old one altogether and fix the failures. |
FlorianDeconinck
approved these changes
May 9, 2025
This was referenced May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With PR NOAA-GFDL/NDSL#104 that function was deprecated in favor of
get_precision(). The new function is a drop-in replacement for the old one. Since we use NDSL version2025.03.00now, we can use the new function name.How Has This Been Tested?
Should be covered by CI.
Checklist: