Update pyFV3 to latest#121
Merged
Merged
Conversation
Updates the pyFV3 submodule to latest to sync it again with NDSL, which was already updated to version 2025.03.00. This PR now updated pyFV3 to a version that also uses that version of NDSL.
7 tasks
Collaborator
Author
fmalatino
approved these changes
May 13, 2025
FlorianDeconinck
approved these changes
May 13, 2025
Collaborator
FlorianDeconinck
left a comment
FlorianDeconinck
left a comment
There was a problem hiding this comment.
LGTM. @fmalatino please merge we don't have the rights
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up from PR #120. I forgot to also update the pyFV3 submodule at the same time. In particular, that PyFV3 update, changes
pyFV3/wrappers/geos_wrapper.pyin which we used the deprecatedfloating_point_precision(). NDSL2025.03.00introducesget_precision()as a drop-in replacement.How Has This Been Tested?
All good as long as CI is still happy.
Checklist: