Skip to content

For release 2025.01.00#102

Merged
fmalatino merged 108 commits into
mainfrom
develop
Jan 24, 2025
Merged

For release 2025.01.00#102
fmalatino merged 108 commits into
mainfrom
develop

Conversation

@fmalatino
Copy link
Copy Markdown
Contributor

Description
This PR will bring the changes from develop into the main branch for release 2025.01.00

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

oelbert and others added 30 commits August 27, 2024 13:15
…_externals

[feature] Expose stencil vertical domain to Frozen Stencil
…reshold_override' into feature/multimodal_metric_threshold_override
…reshold_override' into feature/multimodal_metric_threshold_override
FlorianDeconinck and others added 20 commits December 22, 2024 14:38
[QOL] Fix for boilerplate to work on GPU
Implemented `allreduce` & `Allreduce` for Communicator
* Fix typos
* DaCeProgress: avoid double assignment of prefix
* Add type hints/simplify kernel_theoretical_timing

Adding type hints allowed to simplify `kernel_theoretical_timing`.
Refactor Quantity into a sub-directory
Hotfix for grid generation use of mpi operators
Removes hard-coded version numbers from `__init__` files.
Cleanup: `.gitignore` / `__version__` strings / bunch of typos
Hotfix to netcdf python version
Release candidate: `2025.01.00`
Copy link
Copy Markdown
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The commit list here and yesterday on the develop branch, makes me think we ought to make squash-merge the default for merging into develop and main. That way, in lieu of every commit of every branch, we would have only PR consolidated commits, easier for review of what we are moving in. And we could focus our effort on making sure the messages of those commits are readable and verbose enough.

@FlorianDeconinck
Copy link
Copy Markdown
Collaborator

LGTM

The commit list here and yesterday on the develop branch, makes me think we ought to make squash-merge the default for merging into develop and main. That way, in lieu of every commit of every branch, we would have only PR consolidated commits, easier for review of what we are moving in. And we could focus our effort on making sure the messages of those commits are readable and verbose enough.

For example - for this release there's 108 commits being merged in release, but only a little more than a dozen PR. I'd rather have a neat list of ~12 PR name + description

@bensonr
Copy link
Copy Markdown

bensonr commented Jan 24, 2025

I agree with @FlorianDeconinck on the use of squash commits keeping only the relevant info from the actual merge/PR

Copy link
Copy Markdown
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @FlorianDeconinck as well about squash merging

@fmalatino
Copy link
Copy Markdown
Contributor Author

@FlorianDeconinck and @bensonr, I have now made squash merge the default method moving forward

@fmalatino fmalatino merged commit 729a2fe into main Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants