Skip to content

Cleanup: .gitignore / __version__ strings / bunch of typos#99

Merged
fmalatino merged 3 commits into
NOAA-GFDL:developfrom
romanc:romanc/cleanup-gitignore
Jan 21, 2025
Merged

Cleanup: .gitignore / __version__ strings / bunch of typos#99
fmalatino merged 3 commits into
NOAA-GFDL:developfrom
romanc:romanc/cleanup-gitignore

Conversation

@romanc
Copy link
Copy Markdown
Collaborator

@romanc romanc commented Jan 20, 2025

Description

This clean-up PR contains three commits

  1. Remove examples/mpi/.gitignore and merge its contents with the top-level .gitignore
  2. Remove hard-coded __version__ strings from ndsl/{dsl, stencil}/__init__.py. The version there was 0.2.0, which - to me - looks like they were copied over from the pace repo.
  3. Fix a bunch of typos throughout the codebase and the test cases. Most of it in comments, I rarely touched variable names.

How Has This Been Tested?

Covered by pre-commit hooks and existing test cases.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A

Copy link
Copy Markdown
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much needed cleanup

Copy link
Copy Markdown
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fmalatino fmalatino merged commit 1da613d into NOAA-GFDL:develop Jan 21, 2025
@romanc romanc deleted the romanc/cleanup-gitignore branch January 22, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants