Skip to content

Hotfix for grid generation use of mpi operators#98

Merged
FlorianDeconinck merged 1 commit into
NOAA-GFDL:developfrom
fmalatino:fix/reductop
Jan 16, 2025
Merged

Hotfix for grid generation use of mpi operators#98
FlorianDeconinck merged 1 commit into
NOAA-GFDL:developfrom
fmalatino:fix/reductop

Conversation

@fmalatino
Copy link
Copy Markdown
Contributor

Description
This PR amends the usage of MPIComm.allreduce in ndsl/grid/generation::MetricTerms._reduce_global_area_minmaxes to use ReductionOperator instances instead of built-in methods.

How Has This Been Tested?
Tested using the tests currently include in the github workflow. An additional test of a numpy backend c12 baroclinic, 1x1 layout run will be added to the pace workflow as well to ensure future commits do not effect model runs.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

Copy link
Copy Markdown
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@FlorianDeconinck FlorianDeconinck merged commit a75a1d7 into NOAA-GFDL:develop Jan 16, 2025
@fmalatino fmalatino deleted the fix/reductop branch February 21, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants