Main to dev (2024-05-13)#630
Merged
Merged
Conversation
update to main 20240228 commit
This patch clears out many errors detected by Intel Fortran. Most are false positives from stub functions which would normally be replaced in production and report unset output. These variables are now assigned dummy values in order to pacify the compiler. The `stat` function in POSIX was incorrectly passing its `buf` object to the C `stat` function as `intent(in)`, causing the compiler to believe that the contents were unset. Oddly, this was already working correctly, and perhaps warrants further investigation, but it has now been correctly set to `intent(inout)`. The `ppoly_*` variables in `check_reconstruction_1d` appear to have been incorrectly declared as `out`, when they are clearly used as `in` to validate the values. This has been corrected. `register_diag_field` in the ice shelf diag manager was incorrectly declared and the function appeared to return nothing. Perhaps this function was not used for anything. An IO statement in MOM_open_boundary had a syntax error; this has been fixed. `get_dataset` returns a `dataset_type`, so some compilers expect the stub function to also return a valid `dataset`. Since the stub `dataset_type` contains no fields, any locally declared instance should be sufficient as a return value.
Error cleanup (Intel Fortran)
update to MOM6 main repo 20240401 commit
The default values for the database transfer functions were incorrectly assiged as integer literals, recast to types using real32/64 but actually corresponding to whatever integer kind equals real32/64. We now simply assign it a literal value of -1. and rely on the compiler to handle the recasting. Although none of these functions were intended to be used, and -1 would probably be eventually cast into an appropriate real type, it is better to get this correct. Thanks to Keith Lindsay for suggesting this change.
Replace db array default values with real literals
…0240425 remove compiling warning
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #630 +/- ##
============================================
+ Coverage 37.12% 37.19% +0.06%
============================================
Files 271 541 +270
Lines 80794 161145 +80351
Branches 15082 30005 +14923
============================================
+ Hits 29998 59938 +29940
- Misses 45195 90030 +44835
- Partials 5601 11177 +5576 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/jobs/127929 ✔️ (diag diff is due to updates during regression testing) |
This was referenced May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the contents of mom-ocean#1623 into dev/gfdl.
(This is a bookkeeping PR; the merge will be done externally.)