Simplify set_grid_metrics_from_mosaic#127
Merged
marshallward merged 2 commits intoMay 27, 2022
Merged
Conversation
Simplified the code in set_grid_metrics_from_mosaic and set_coord_from_file using the scale argument to MOM_read_data, eliminating several arrays that are no longer needed. Also added a call to set RAD_EARTH via get_param for grids where it is not otherwise set, replacing a hard-coded constant. The variable G%Rad_Earth is used in a few places even in these cases, so it should be logged as a run-time parameter. All answers are bitwise identical, although there are new entries in some MOM_parameter_doc.all files.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #127 +/- ##
============================================
- Coverage 33.47% 33.45% -0.02%
============================================
Files 262 262
Lines 71400 71384 -16
Branches 13323 13323
============================================
- Hits 23899 23884 -15
+ Misses 43029 43028 -1
Partials 4472 4472
Continue to review full report at Codecov.
|
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/jobs/78475 ✔️ 🟡 New parameter:
|
marshallward
approved these changes
May 27, 2022
kshedstrom
pushed a commit
to ESMG/MOM6
that referenced
this pull request
May 1, 2024
…in-20240228 update to main 20240228 commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplified the code in set_grid_metrics_from_mosaic and set_coord_from_file
using the scale argument to MOM_read_data, eliminating several arrays that are
no longer needed. Also added a call to set RAD_EARTH via get_param for grids
where it is not otherwise set, replacing a hard-coded constant. The variable
G%Rad_Earth is used in a few places even in these cases, so it should be logged
as a run-time parameter. All answers are bitwise identical, although there are
new entries in some MOM_parameter_doc.all files.