Rescale ice shelf temperatures#130
Merged
marshallward merged 3 commits intoJun 5, 2022
Merged
Conversation
Applied dimensional rescaling of all of the ice shelf temperature and salinity variables that could be modified without requiring any changes at the driver level. There is a new unit_scale_type argument to MOM_IS_diag_mediator_init, mirroring what is done in MOM_diag_mediator_init. This commit also includes changing the initial values in the stencil array from -1 to 0, but this initialization appears to be unnecessary. A large number of comments were added, corrected, or modified. All answers in the test cases are bitwise identical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #130 +/- ##
============================================
- Coverage 33.45% 33.45% -0.01%
============================================
Files 262 262
Lines 71385 71388 +3
Branches 13323 13323
============================================
Hits 23884 23884
- Misses 43029 43032 +3
Partials 4472 4472
Continue to review full report at Codecov.
|
Member
Author
|
Olga Sergienko will be providing a review of this PR after she gets back from the EGU meeting. If she has not done this yet, this PR can be temporarily bypassed. |
OlgaSergienko
approved these changes
Jun 1, 2022
OlgaSergienko
left a comment
OlgaSergienko
left a comment
There was a problem hiding this comment.
All made changes are necessary, the code runs as intended.
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15714 ✔️ |
marshallward
approved these changes
Jun 5, 2022
Member
marshallward
left a comment
marshallward
left a comment
There was a problem hiding this comment.
Approved on behalf of @OlgaSergienko
kshedstrom
pushed a commit
to ESMG/MOM6
that referenced
this pull request
May 1, 2024
Error cleanup (Intel Fortran)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied dimensional rescaling of all of the ice shelf temperature and salinity
variables that could be modified without requiring any changes at the driver
level. There is a new unit_scale_type argument to MOM_IS_diag_mediator_init,
mirroring what is done in MOM_diag_mediator_init. This commit also includes
changing the initial values in the stencil array from -1 to 0, but this
initialization appears to be unnecessary. A large number of comments were
added, corrected, or modified. All answers in the test cases are bitwise
identical.