master -> dev/gfdl synchronization#99
Merged
Merged
Conversation
Tile index to `grid_global` was not correct inside a loop over tiles.
Fix mesh generation in init_grid()
…for the 202101 public release of GFDL_atmos_cubed_sphere
…s in master and to bring in changes from SHiELD/atmosphere.F90. Minor change to driver/SHiELD/atmosphere.F90.
…_public 202101 public release
Corrected information for the 202101 public release.
Fixed a bug where model could not correctly initialize grids for regional domains
Fix for GNU compiler
Vulcan: adding condition to coarsening_factor
Implementing Pull Request Template
remove trailiing spaces
fixes missing argument in store_data for case where GFS_PHYS macro no…
add in test for do_cube_transform in fv_grid_tool::init_grid
fixes bug in regional bc time calculation in fv_tracer2d.F90
laurenchilutti
approved these changes
Apr 30, 2021
thomas-robinson
approved these changes
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brings in the science updates from the 2021 January Release into the dev/gfdl branch.
The fv_mapz.F90 file has been reverted to the existing version in dev/gfdl in order to maintain reproducibility.
This will require changes to xmls. There will need to be these files added:
GFDL_atmos_cubed_sphere/driver/SHiELD/cloud_diagnosis.F90
GFDL_atmos_cubed_sphere/driver/SHiELD/gfdl_cloud_microphys.F90 driver
and this directory can be removed
GFDL_atmos_cubed_sphere/model_nh_null
This PR must come before PR #98 is brought into dev/gfdl
No issue created
How Has This Been Tested?
This has been tested via mdt/xml (hash: 883498) for AM4p0, CM4_piContol_C, ESM4_piControl_D experiments. All answer reproduce.
Checklist:
Please check all whether they apply or not