fixes bug in regional bc time calculation in fv_tracer2d.F90#92
Merged
Conversation
lharris4
approved these changes
Apr 5, 2021
Contributor
lharris4
left a comment
There was a problem hiding this comment.
The fix now gives the correct behavior. Earlier behavior would act to greatly extend the extrapolation, leading to potentially very large values of the incoming tracer (or perhaps even negatives), leading to artifacts and instability.
laurenchilutti
approved these changes
Apr 5, 2021
climbfuji
pushed a commit
to climbfuji/GFDL_atmos_cubed_sphere
that referenced
this pull request
Apr 24, 2024
GitFlow: Merge develop into main for release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug identified during the merge into dev/emc. The bug affects the time trigger for the regional bc updates.
Fixes # (issue)
How Has This Been Tested?
Tested via dev/emc merge.
Checklist:
Please check all whether they apply or not