add in test for do_cube_transform in fv_grid_tool::init_grid#91
Merged
Conversation
Contributor
|
Looks good. This version of the cube rotation fixes the problem in which tile 6 was upside down. I am hoping that this can eventually be supported by the external tools (something that FV3lib would help with). |
lharris4
approved these changes
Apr 3, 2021
Contributor
lharris4
left a comment
There was a problem hiding this comment.
Looks good. See my comment for my explanation of this new functionality.
laurenchilutti
approved these changes
Apr 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Re-introduces a fix from dev/gfdl that should be in master. This update changes an else to an elseif conditional around a call to cube_transform in fv_grid_tools::init_grid. This function is an option for generating a stretched grid internally. Without this conditional, all internally generated grids run through this function and will not match a grid generated externally.
Fixes # (issue) - no issue created
How Has This Been Tested?
This has been tested as part of the merge of master -> dev/gfdl.
Checklist:
Please check all whether they apply or not