Skip to content

[production/GFS.v17] Relax TA_dyn wanring range#405

Merged
laurenchilutti merged 1 commit into
NOAA-GFDL:production/GFS.v17from
dpsarmie:v17/relax_warning_range
Feb 26, 2026
Merged

[production/GFS.v17] Relax TA_dyn wanring range#405
laurenchilutti merged 1 commit into
NOAA-GFDL:production/GFS.v17from
dpsarmie:v17/relax_warning_range

Conversation

@dpsarmie
Copy link
Copy Markdown

Description

There was a previous fix that relaxed the temperature range for warnings in a previous PR ( #381 ). This range was not applied to the TA_dyn variable at the time. The GFS team has requested that TA_dyn range should also be changed.

This will be put into the production branch for now. There can be a wider discussion to see if this needs to go into dev/emc.

How Has This Been Tested?

This change was tested using the UFSWM regression test suite.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@dpsarmie
Copy link
Copy Markdown
Author

@RuiyuSun @XiaqiongZhou-NOAA This is the fix for the logging issue seen in the v17 retro runs.

@laurenchilutti This can get merged into the production branch as soon as it gets the needed reviews in.

@laurenchilutti
Copy link
Copy Markdown
Member

How can I assist in starting the wider conversation on including this in the dev/emc branch? I would like to see this go into the dev/emc branch too so that the next version of GFS can use the dev/emc branch.

@RuiyuSun
Copy link
Copy Markdown

Thanks @dpsarmie!

@dpsarmie
Copy link
Copy Markdown
Author

How can I assist in starting the wider conversation on including this in the dev/emc branch? I would like to see this go into the dev/emc branch too so that the next version of GFS can use the dev/emc branch.

I was probably just being overly cautious and not jumping to the assumption that this was automatically going into dev/emc. But if Kate, Ruiyu, and you agree then that's probably enough? I don't know who else would want to chime in.

Either way, we could merge this PR and then I can create a dev/emc PR and ping more people if needed.

@dpsarmie
Copy link
Copy Markdown
Author

@laurenchilutti @vithikashah001 Let me know if there's anything else needed from us to get this PR merged into the production branch.

@laurenchilutti laurenchilutti merged commit af77d0f into NOAA-GFDL:production/GFS.v17 Feb 26, 2026
@laurenchilutti
Copy link
Copy Markdown
Member

@dpsarmie Could you go ahead and create a dev/emc branch PR for this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants