Removal of some goto statements#391
Conversation
|
@dpsarmie Will this be the changes that need to go into production/GFS.v17? |
|
@laurenchilutti Thank you for creating the production branch. I need to clean this PR up but yes, this will go in both the For this PR, I'm going to split off the more complex changes and changes that are not covered by the current suite of UFSWM regression tests just out of an abundance of caution. I'll get this PR cleaned up before lunch today since I finished my final testing. It'll be ready for review at that time. Thanks again! |
|
@laurenchilutti I was doing more testing so there was a small delay. This should be fine for review. I'll place the other more involved changes in a separate PR. |
|
Do you want to include the changes from the GFS production branch here in this PR? #405 |
Ok, I added the changes. I'll get the PRs in UFSATM and UFSWM opened so this can get a place in the queue. |
|
Testing has completed successfully on ufs-community/ufs-weather-model#3169. This PR can be merged. |
Description
This PR will remove some
gotoanddo continuestatements and replace them with more modern code syntax. This is a request from NCO across all subroutines that are in UFS.Fixes #390
See NOAA-EMC/GFS#19 for more details.
There will be a second PR made with more goto removals. Those changes will not be added since they are outside the scope of the regression tests and will require more scrutiny.
How Has This Been Tested?
Changes have been tested against the UFS regression test suite. There are no changes to the baselines and there should be no changes once the PR is ready to be merged.
Checklist:
Please check all whether they apply or not