Add a new parameter to control cutoff level for implicit RF#381
Conversation
|
@XiaqiongZhou-NOAA this is a nice addition, thank you. |
|
@XiaqiongZhou-NOAA Kate, can you add reviewers and get this PR ready for commit as early as possible ? For now we can set the default rf_cutoff_fast to be same as the rf_cutoff. |
bensonr
left a comment
There was a problem hiding this comment.
While technically this all looks good, I am concerned with the choice of rf_cutoff_fast for the variable name. There is a Ray_fast routine for simple calculation and your new variable name seems to be independent of that logic, but could be mistaken as being related to it.
|
@bensonr To be consistent with Also @yangfanglin could we understand some more of the motivation for this change and what positive effects it may have? |
|
@lharris4 |
|
NASA's TIMED mission and satellite limb sounders have modeled and observed mesopause temperatures as low as 123 K (-150°C). Experimental GFSv17 (C1152) prints a lot of low temperature warnings that slows down model performance and even at times causes model to exceed assigned CPU hours. |
|
@XiaqiongZhou-NOAA @yangfanglin the low temperature warnings are getting to be annoying in a number of contexts. I would recommend setting A pressure- or otherwise context-dependent temperature check would be ideal, but not a priority at this time (perhaps something better suited for PyFV3). |
|
Testing on #2730 is complete, please continue with the merge process. |
|
@FernandoAndrade-NOAA Merge is complete. |
Description
A new parameter rf_cutoff_fast is introduced to independently control the cutoff level for implicit Rayleigh damping when fast_tau_w_sec>0, decoupling it from the cutoff level (rf_cutoff) used for explicit damping.
How Has This Been Tested?
It is tested on HERA with intel compiler
Checklist:
Please check all whether they apply or not