Skip to content

Add a new parameter to control cutoff level for implicit RF#381

Merged
laurenchilutti merged 5 commits into
NOAA-GFDL:dev/emcfrom
XiaqiongZhou-NOAA:rf_fast_w
Jun 12, 2025
Merged

Add a new parameter to control cutoff level for implicit RF#381
laurenchilutti merged 5 commits into
NOAA-GFDL:dev/emcfrom
XiaqiongZhou-NOAA:rf_fast_w

Conversation

@XiaqiongZhou-NOAA
Copy link
Copy Markdown
Contributor

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA commented May 8, 2025

Description

A new parameter rf_cutoff_fast is introduced to independently control the cutoff level for implicit Rayleigh damping when fast_tau_w_sec>0, decoupling it from the cutoff level (rf_cutoff) used for explicit damping.

How Has This Been Tested?

It is tested on HERA with intel compiler

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA changed the title Add a new parameter Add a new parameter to control cutoff level for implicit RF May 8, 2025
@lharris4
Copy link
Copy Markdown
Contributor

lharris4 commented May 9, 2025

@XiaqiongZhou-NOAA this is a nice addition, thank you.

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA marked this pull request as ready for review May 12, 2025 16:06
@yangfanglin
Copy link
Copy Markdown

@XiaqiongZhou-NOAA Kate, can you add reviewers and get this PR ready for commit as early as possible ? For now we can set the default rf_cutoff_fast to be same as the rf_cutoff.

Copy link
Copy Markdown
Contributor

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While technically this all looks good, I am concerned with the choice of rf_cutoff_fast for the variable name. There is a Ray_fast routine for simple calculation and your new variable name seems to be independent of that logic, but could be mistaken as being related to it.

@lharris4
Copy link
Copy Markdown
Contributor

@bensonr To be consistent with fast_tau_w_sec, perhaps the best name would be rf_cutoff_w. I admit that there is a namespace clash with RF_fast() although this has largely been deprecated in favor of this w damping.

Also @yangfanglin could we understand some more of the motivation for this change and what positive effects it may have?

@XiaqiongZhou-NOAA
Copy link
Copy Markdown
Contributor Author

@bensonr @lucas: Thanks. I will change the parameter name.
Lucas: When we tried to limit all RF above 1hPa, it turns out that the polar vortex has a strong bias. This modification will allow us keep implicit w damping at 1hPa but with lower rf_cutoff to reduce that bias.

Comment thread model/fv_control.F90 Outdated
@XiaqiongZhou-NOAA
Copy link
Copy Markdown
Contributor Author

@lharris4
I would like to add the modify in this PR by changing "trange_bad = (/ 150., 350. /) ! temperature" to (120 to 350) in fv_diagnostics.F90. As our model is up to 80km and C1152 resolution, 150K seems not very warning. Any suggestions?

@yangfanglin
Copy link
Copy Markdown

yangfanglin commented May 20, 2025

NASA's TIMED mission and satellite limb sounders have modeled and observed mesopause temperatures as low as 123 K (-150°C). Experimental GFSv17 (C1152) prints a lot of low temperature warnings that slows down model performance and even at times causes model to exceed assigned CPU hours.

@lharris4
Copy link
Copy Markdown
Contributor

@XiaqiongZhou-NOAA @yangfanglin the low temperature warnings are getting to be annoying in a number of contexts. I would recommend setting trange_bad = (/50., 350.).

A pressure- or otherwise context-dependent temperature check would be ideal, but not a priority at this time (perhaps something better suited for PyFV3).

@FernandoAndrade-NOAA
Copy link
Copy Markdown

Testing on #2730 is complete, please continue with the merge process.

@laurenchilutti laurenchilutti merged commit ac7c36b into NOAA-GFDL:dev/emc Jun 12, 2025
@laurenchilutti
Copy link
Copy Markdown
Member

@FernandoAndrade-NOAA Merge is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants