Skip to content

Fix intel debug warnings (implicit i,j,k; explicit mpi interface) #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vithikashah001 merged 2 commits into from
Nov 4, 2025
Merged

Fix intel debug warnings (implicit i,j,k; explicit mpi interface) #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
583ec6c
Fix intel debug warnings (implicit i,j,k; explicit mpi interface)
NickSzapiro-NOAA Oct 10, 2025
3e358e4
Merge dev/emc into fix_warnings
NickSzapiro-NOAA Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions model/fv_arrays.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2177,6 +2177,8 @@ subroutine allocate_fv_nest_BC_type_3D(BC,is,ie,js,je,isd,ied,jsd,jed,npx,npy,np

integer, intent(IN) :: is, ie, js, je, isd, ied, jsd, jed, npx, npy, npz, ng

integer :: i, j, k

Copy link
Copy Markdown
Contributor

@JosephMouallem JosephMouallem Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch, we could also fix this in the main branch.

if (BC%allocated) return


Expand Down
20 changes: 10 additions & 10 deletions model/fv_regional_bc.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6657,7 +6657,7 @@ end subroutine apply_delz_boundary
!---------------------------------------------------------------------

subroutine exch_uv(domain, bd, npz, u, v)
use mpi
use mpi_f08

implicit none

Expand All @@ -6667,9 +6667,15 @@ subroutine exch_uv(domain, bd, npz, u, v)
real, intent(inout) :: u (bd%isd:bd%ied ,bd%jsd:bd%jed+1,1:npz)
real, intent(inout) :: v (bd%isd:bd%ied+1,bd%jsd:bd%jed ,1:npz)

real, dimension(:), allocatable :: buf1,buf2,buf3,buf4
integer :: ihandle1,ihandle2,ihandle3,ihandle4
integer,dimension(MPI_STATUS_SIZE) :: istat
#ifdef OVERLOAD_R4
#define _DYN_MPI_REAL MPI_REAL
real(kind=4), dimension(:), allocatable :: buf1,buf2,buf3,buf4
#else
#define _DYN_MPI_REAL MPI_DOUBLE_PRECISION
real(kind=8), dimension(:), allocatable :: buf1,buf2,buf3,buf4
#endif
type(MPI_Request) :: ihandle1,ihandle2,ihandle3,ihandle4
type(MPI_Status) :: istat
integer :: ic, i, j, k, is, ie, js, je
integer :: irecv, isend, ierr

Expand Down Expand Up @@ -6704,12 +6710,6 @@ subroutine exch_uv(domain, bd, npz, u, v)

! FIXME: MPI_COMM_WORLD

#ifdef OVERLOAD_R4
#define _DYN_MPI_REAL MPI_REAL
#else
#define _DYN_MPI_REAL MPI_DOUBLE_PRECISION
#endif

! Receive from north
if( north_pe /= NULL_PE )then
call MPI_Irecv(buf1,size(buf1),_DYN_MPI_REAL,north_pe,north_pe &
Expand Down
Loading