Skip to content

Add a new parameter to control cutoff level for implicit RF#962

Merged
jkbk2004 merged 5 commits into
NOAA-EMC:developfrom
XiaqiongZhou-NOAA:rf_fast_w
Jun 12, 2025
Merged

Add a new parameter to control cutoff level for implicit RF#962
jkbk2004 merged 5 commits into
NOAA-EMC:developfrom
XiaqiongZhou-NOAA:rf_fast_w

Conversation

@XiaqiongZhou-NOAA
Copy link
Copy Markdown
Contributor

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA commented May 8, 2025

Description

A new parameter rf_cutoff_fast is introduced in dynamics to independently control the cutoff level for implicit Rayleigh damping when fast_tau_w_sec>0, decoupling it from the cutoff level (rf_cutoff) used for explicit damping when tau>0.
The default value of rf_cutoff_fast=100. (1hPa). It changes the results in RTs with fast_tau_w_sec>0 with rt_cutoff is not equal to 100.

Testing

Tested on Hera with intel compiler. It will change the regression tests with fast_tau_w_sec>0 and rt_cutoff is not equal to 100.
How were these changes tested?

Dependencies

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA marked this pull request as ready for review May 12, 2025 16:07
@XiaqiongZhou-NOAA XiaqiongZhou-NOAA changed the title Point fv3/atmos_cubed_sphere to personal branch Add a new parameter to control cutoff level for implicit RF May 12, 2025
@RuiyuSun RuiyuSun added this to GFS v17 May 22, 2025
@RuiyuSun RuiyuSun moved this to In Progress in GFS v17 May 22, 2025
@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

Waiting on work to be done to bring this and atmos_cubed_sphere up to top of their authoritative branches and updating the hashes before approving for work to start in UFSWM.

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

atmos_cubed_sphere sub PR has been merged, please revert .gitmodules and resync hashes, thank you.

@XiaqiongZhou-NOAA
Copy link
Copy Markdown
Contributor Author

atmos_cubed_sphere sub PR has been merged, please revert .gitmodules and resync hashes, thank you.

Done.

@jkbk2004 jkbk2004 merged commit 357ff49 into NOAA-EMC:develop Jun 12, 2025
3 of 8 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in GFS v17 Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants