Add a new parameter to control cutoff level for implicit RF#962
Merged
Conversation
13 tasks
RuiyuSun
approved these changes
May 20, 2025
Collaborator
|
Waiting on work to be done to bring this and atmos_cubed_sphere up to top of their authoritative branches and updating the hashes before approving for work to start in UFSWM. |
Collaborator
|
atmos_cubed_sphere sub PR has been merged, please revert .gitmodules and resync hashes, thank you. |
Contributor
Author
Done. |
jkbk2004
approved these changes
Jun 12, 2025
BrianCurtis-NOAA
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A new parameter rf_cutoff_fast is introduced in dynamics to independently control the cutoff level for implicit Rayleigh damping when fast_tau_w_sec>0, decoupling it from the cutoff level (rf_cutoff) used for explicit damping when tau>0.
The default value of rf_cutoff_fast=100. (1hPa). It changes the results in RTs with fast_tau_w_sec>0 with rt_cutoff is not equal to 100.
Testing
Tested on Hera with intel compiler. It will change the regression tests with fast_tau_w_sec>0 and rt_cutoff is not equal to 100.
How were these changes tested?
Dependencies