Fix for JEDI cubed sphere grid#951
Closed
DusanJovic-NOAA wants to merge 1 commit into
Closed
Conversation
14 tasks
9 tasks
jkbk2004
approved these changes
Apr 21, 2025
jkbk2004
pushed a commit
that referenced
this pull request
Apr 23, 2025
…D_CI_TESTING in CMake, to allow ufs-weather-model to use BUILD_TESTING #920 + Fix for JEDI cubed sphere grid #951 (#931) * change cmake option BUILD_TESTING to BUILD_CI_TESTING * fixed workflow * Reorganize project structure to allow multiple dycores. Isolate FV3 dycore. * Fix JEDI cubed sphere grid and issue with time unlimited --------- Co-authored-by: Edward Hartnett <edward.hartnett@noaa.gov> Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>
Collaborator
|
merged with #931 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recent updates in write grid component unintentionally changed the time dimension to unlimited and also the type of native history files from multi-tile to single tile depending on the value of output_grid parameter, which it shouldn't. This PR reverts both of these to their previous behavior. For details, see: NOAA-EMC/global-workflow#3593
No change of baselines is expected.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested? Yes
What compilers / HPCs was it tested with? Intel and GNU
Are the changes covered by regression tests? Yes.
Have the ufs-weather-model regression test been run? Yes. On what platform? Hera
Dependencies
No.