Change BUILD_TESTING to BUILD_CI_TESTING in CMake, to allow ufs-weather-model to use BUILD_TESTING#920
Closed
edwardhartnett wants to merge 2 commits into
Closed
Change BUILD_TESTING to BUILD_CI_TESTING in CMake, to allow ufs-weather-model to use BUILD_TESTING#920edwardhartnett wants to merge 2 commits into
edwardhartnett wants to merge 2 commits into
Conversation
DusanJovic-NOAA
requested review from
AlexanderRichert-NOAA and
DusanJovic-NOAA
DusanJovic-NOAA
approved these changes
Feb 7, 2025
AlexanderRichert-NOAA
approved these changes
Feb 7, 2025
Collaborator
|
It looks like this will close ufs-community/ufs-weather-model#2648 - thanks @DusanJovic-NOAA for the pointer. |
jkbk2004
added a commit
to scrasmussen/ufsatm
that referenced
this pull request
Apr 22, 2025
jkbk2004
pushed a commit
that referenced
this pull request
Apr 23, 2025
…D_CI_TESTING in CMake, to allow ufs-weather-model to use BUILD_TESTING #920 + Fix for JEDI cubed sphere grid #951 (#931) * change cmake option BUILD_TESTING to BUILD_CI_TESTING * fixed workflow * Reorganize project structure to allow multiple dycores. Isolate FV3 dycore. * Fix JEDI cubed sphere grid and issue with time unlimited --------- Co-authored-by: Edward Hartnett <edward.hartnett@noaa.gov> Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>
Collaborator
|
merged with #931 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BUILD_TESTING was used by @AlexanderRichert-NOAA to get the fv3atm special build working. It's necessary because fv3atm contains code that links to subcomponent code, and that doesn't build on its own.
But BUILD_TESTING is a standard CMake option that has other uses. So instead, we should use BUILD_CI_TESTING for our own home-rolled hackery to build fv3atm in the CI system.
Issue(s) addressed
Fixes #821
Testing
In CI
Dependencies
None.